Page MenuHomePhabricator

Improve tests regarding imported namespaces and chained calls in C++
ClosedPublic

Authored by paulherman on Aug 19 2015, 11:56 AM.

Details

Diff Detail

Event Timeline

paulherman retitled this revision from to Improve tests regarding imported namespaces and chained calls in C++.
paulherman updated this object.
paulherman added a reviewer: sivachandra.
paulherman added a subscriber: lldb-commits.
chaoren requested changes to this revision.Aug 19 2015, 12:00 PM
chaoren added a reviewer: chaoren.
chaoren added a subscriber: chaoren.
chaoren added inline comments.
test/lang/cpp/chained-calls/TestCppChainedCalls.py
45

Please use self.get_process_working_directory() instead of cwd for remote tests.

This revision now requires changes to proceed.Aug 19 2015, 12:00 PM
paulherman edited edge metadata.

Improve tests regarding imported namespaces and chained calls in C++

sivachandra accepted this revision.Aug 19 2015, 2:02 PM
sivachandra edited edge metadata.

LGTM

chaoren requested changes to this revision.Aug 19 2015, 2:57 PM
chaoren edited edge metadata.
chaoren added inline comments.
test/lang/cpp/nsimport/TestCppNsImport.py
37

You shouldn't make the change here, since the location of the target binary wrt CreateTarget is indeed os.getcwd(), but the working directory wrt to LaunchSimple could be an arbitrary remote path.

This revision now requires changes to proceed.Aug 19 2015, 2:57 PM
chaoren accepted this revision.Sep 16 2015, 11:24 AM
chaoren edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2015, 11:24 AM
chaoren closed this revision.Sep 16 2015, 11:24 AM