Page MenuHomePhabricator

paulherman (Paul Herman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2015, 4:52 PM (328 w, 1 d)

Recent Activity

Aug 23 2021

paulherman added a comment to D108525: Fix documentation and snippets for the handle attributes..

Thanks for the very prompt review! I'm afraid I no longer have permissions to submit --my last commit was in 2015 and I recall that I had SVN access, but many things have changed. Would it be possible to submit this on my behalf?

I'm happy to commit on your behalf -- what name and email address would you like me to use for patch attribution?

Aug 23 2021, 1:07 PM · Restricted Project
paulherman added a comment to D108525: Fix documentation and snippets for the handle attributes..

Thanks for the very prompt review! I'm afraid I no longer have permissions to submit --my last commit was in 2015 and I recall that I had SVN access, but many things have changed. Would it be possible to submit this on my behalf?

Aug 23 2021, 12:31 PM · Restricted Project
paulherman updated the diff for D108525: Fix documentation and snippets for the handle attributes..

Explaining the tag argument.

Aug 23 2021, 9:22 AM · Restricted Project

Aug 22 2021

paulherman added a reviewer for D108525: Fix documentation and snippets for the handle attributes.: xazax.hun.
Aug 22 2021, 2:20 PM · Restricted Project
paulherman requested review of D108525: Fix documentation and snippets for the handle attributes..
Aug 22 2021, 2:09 PM · Restricted Project
paulherman added inline comments to D70469: [attributes] [analyzer] Add handle related attributes.
Aug 22 2021, 1:56 PM · Restricted Project

Sep 17 2015

paulherman committed rL247923: Fix caching for clang::Decl in DWARFASTParserClang.
Fix caching for clang::Decl in DWARFASTParserClang
Sep 17 2015, 12:33 PM
paulherman closed D12942: Fix caching for clang::Decl in DWARFASTParserClang.
Sep 17 2015, 12:33 PM
paulherman updated the diff for D12942: Fix caching for clang::Decl in DWARFASTParserClang.

Fix caching for clang::Decl in DWARFASTParserClang

Sep 17 2015, 12:32 PM
paulherman updated the diff for D12942: Fix caching for clang::Decl in DWARFASTParserClang.

Fix caching for clang::Decl in DWARFASTParserClang

Sep 17 2015, 11:00 AM
paulherman updated the diff for D12942: Fix caching for clang::Decl in DWARFASTParserClang.

Fix caching for clang::Decl in DWARFASTParserClang

Sep 17 2015, 10:54 AM
paulherman retitled D12942: Fix caching for clang::Decl in DWARFASTParserClang from to Fix caching for clang::Decl in DWARFASTParserClang.
Sep 17 2015, 10:39 AM

Sep 16 2015

paulherman abandoned D12304: Add scope tree for variable searching.
Sep 16 2015, 2:32 PM
paulherman committed rL247836: Add using directives to the clang::DeclContext and fix decls for variables….
Add using directives to the clang::DeclContext and fix decls for variables…
Sep 16 2015, 11:50 AM
paulherman closed D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces.
Sep 16 2015, 11:49 AM
paulherman updated the diff for D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces.

Add using directives to the clang::DeclContext and fix decls for variables inside namespaces

Sep 16 2015, 11:48 AM
paulherman added a comment to D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces.

The need for ParseDeclsInContext is to get a list of namespaces that are contained within a using-directive. This does not actually parse anything but DW_TAG_imported_namespace and DW_TAG_imported_decl. The actual contents of the namespace are parsed only when the search reaches it.

Sep 16 2015, 10:34 AM

Sep 15 2015

paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Please also look at http://reviews.llvm.org/D12897

Sep 15 2015, 10:03 PM
paulherman retitled D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces from to Add using directives to the clang::DeclContext and fix decls for variables inside namespaces.
Sep 15 2015, 8:37 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

The test was supposed to be marked as an XFAIL. I'm currently writing a fix for this that reports ambiguity in a context and deals with imported decls.

Sep 15 2015, 5:36 PM
paulherman committed rL247760: Fix double include in CompilerDeclContext.h.
Fix double include in CompilerDeclContext.h
Sep 15 2015, 5:30 PM
paulherman committed rL247759: Fix missing include in CompilerDeclContext.h.
Fix missing include in CompilerDeclContext.h
Sep 15 2015, 5:27 PM
paulherman committed rL247746: Search variables based on clang::DeclContext and clang::Decl tree.
Search variables based on clang::DeclContext and clang::Decl tree
Sep 15 2015, 4:46 PM
paulherman closed D12658: Search variables based on clang::DeclContext and clang::Decl tree.
Sep 15 2015, 4:45 PM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 15 2015, 4:43 PM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 15 2015, 11:55 AM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 15 2015, 10:37 AM

Sep 14 2015

paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 14 2015, 5:55 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

I just ran a grep through the source. It seems that everywhere it is created as a shared_ptr. In a previous attempt I tried storing it in the TypeSystem map from decl to object as Variable* instead of VariableSP and it seemed like at some point between launching a query and getting the value of a variable there were no references so the pointer got deleted. Hence, I guess it is kinda needed here.

Sep 14 2015, 5:35 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

So I don't like it in ParseVariableDIE() because it means we must create the decl right away for the variable when parsing it. ParseVariableDIE is used to parse all variables everywhere and we don't need the CompilerDecl in order to display the Variable, so we don't need to create it right away. We can always associate it in the Variable::GetDecl() call.

Sep 14 2015, 5:09 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

I thought about the problem a bit more and I believe that having the call to DeclLinkDeclToObject inside ParseVariableDIE makes sense since this gets called only when the variable will actually be used in a search together with its context. Also, since ParseVariableDIE is lazy, this makes the linking to be lazy.

Sep 14 2015, 4:41 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

If I move the call to DeclLinkDeclToObject inside any of the GetDeclXXX methods, then there is no way to access the VariableSP needed for the call and it is probably harder to reconstruct the parameters needed for ParseVariableDIE starting from just the DIE itself.

Sep 14 2015, 1:57 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Are you suggesting that the DeclLinkToObject is moved inside the GetDecl call and I only remove that? This is the only place where GetDecl is called, so it would be equivalent from a computational point of view. This is because ClangASTContext::DeclContextFindDeclByName assumes that the Decl tree is computed (hence a call to ParseVariablesForContext was placed).

Sep 14 2015, 1:38 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

I think the only concern left might be the call to DeclLinkToObject in ParseVariableDIE. It doesn't have anything to do with clang but I feel like there should be a way to do this lazily.

Sep 14 2015, 12:02 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

[WIP] Search variables based on clang::DeclContext and clang::Decl tree

This revision fixes some of the comments. There are some things I'm not sure about. The problem is that at some point there will be the need to link decls with the object they represent (Function, Variable, CompileUnit, etc). Is the approach of getting the VariableSP from the TypeSystem the right one?

It is fine because each TypeSystem does have a link to its SymbolFile, so yes this will work.

Also, should ParseVariableDIE be moved to DWARFASTParser in order to create the decl there or should there only be a method CreateVariableDecl(VariableSP var)?

No. ParseVariableDIE shouldn't be making the CompilerDecl at all. We should do this only when we call the "Variable::GetDecl()". It should then route this through the TypeSystem from the variable type and ask the type system for the CompilerDecl. This will get routed to the SymbolFile and then to that will get routed to the DWARFASTParser (DWARFASTParserClang for this case).

Sep 14 2015, 11:52 AM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 14 2015, 11:25 AM

Sep 11 2015

paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 11 2015, 7:37 PM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

[WIP] Search variables based on clang::DeclContext and clang::Decl tree

Sep 11 2015, 5:31 PM

Sep 10 2015

paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

I believe that the approach of CompilerDeclContext::FindDecls could be better. But then this kind of forces CompilerDeclContext to inherit CompilerDecl (a function is both a DeclContext and a Decl) and I believe that creating a class for each possible entity is an overkill.

Sep 10 2015, 5:23 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

I agree with most of your comments and will fix them.

Sep 10 2015, 4:09 PM
paulherman added a comment to D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Ping.

Sep 10 2015, 2:57 PM

Sep 9 2015

paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 9 2015, 10:56 AM

Sep 8 2015

paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 8 2015, 5:59 PM
paulherman updated D12658: Search variables based on clang::DeclContext and clang::Decl tree.
Sep 8 2015, 5:51 PM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 8 2015, 5:48 PM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 8 2015, 3:38 PM
paulherman updated the diff for D12658: Search variables based on clang::DeclContext and clang::Decl tree.

Search variables based on clang::DeclContext and clang::Decl tree

Sep 8 2015, 12:24 PM

Sep 4 2015

paulherman retitled D12658: Search variables based on clang::DeclContext and clang::Decl tree from to Search variables based on clang::DeclContext and clang::Decl tree.
Sep 4 2015, 7:24 PM

Aug 27 2015

paulherman updated the diff for D12304: Add scope tree for variable searching.

Add scope tree for variable searching

Aug 27 2015, 12:14 PM
paulherman added a reviewer for D12304: Add scope tree for variable searching: clayborg.
Aug 27 2015, 11:50 AM

Aug 26 2015

paulherman updated the diff for D12304: Add scope tree for variable searching.

Add scope tree for variable searching

Aug 26 2015, 4:58 PM
paulherman updated the diff for D12304: Add scope tree for variable searching.

Add scope tree for variable searching

Aug 26 2015, 10:18 AM

Aug 25 2015

paulherman updated the diff for D12304: Add scope tree for variable searching.

Add scope tree for variable searching

Aug 25 2015, 4:22 PM
paulherman updated the diff for D12304: Add scope tree for variable searching.

Add scope tree for variable searching

Aug 25 2015, 3:49 PM
paulherman updated D12304: Add scope tree for variable searching.
Aug 25 2015, 12:29 PM
paulherman updated the diff for D12304: Add scope tree for variable searching.

Add scope tree for variable searching

Aug 25 2015, 12:02 PM

Aug 24 2015

paulherman updated D12304: Add scope tree for variable searching.
Aug 24 2015, 5:47 PM
paulherman retitled D12304: Add scope tree for variable searching from to Add scope tree for variable searching.
Aug 24 2015, 5:06 PM

Aug 20 2015

paulherman closed D11543: Fix evaluation of global operators in C++.
Aug 20 2015, 12:30 PM
paulherman closed D12044: Fix resolution conflict between global and class static variables in C++..
Aug 20 2015, 12:29 PM
paulherman closed D11204: Test chained function calls in C++.
Aug 20 2015, 12:20 PM

Aug 19 2015

paulherman committed rL245515: Fix tests to work on remote targets..
Fix tests to work on remote targets.
Aug 19 2015, 3:45 PM
paulherman committed rL245508: Fix evaluation of global operators in C++.
Fix evaluation of global operators in C++
Aug 19 2015, 2:45 PM
paulherman committed rL245505: Improve tests regarding imported namespaces and chained calls in C++.
Improve tests regarding imported namespaces and chained calls in C++
Aug 19 2015, 2:24 PM
paulherman updated the diff for D12165: Improve tests regarding imported namespaces and chained calls in C++.

Improve tests regarding imported namespaces and chained calls in C++

Aug 19 2015, 12:03 PM
paulherman retitled D12165: Improve tests regarding imported namespaces and chained calls in C++ from to Improve tests regarding imported namespaces and chained calls in C++.
Aug 19 2015, 11:56 AM

Aug 18 2015

paulherman added a comment to D11543: Fix evaluation of global operators in C++.

Ping

Aug 18 2015, 5:16 PM
paulherman committed rL245381: Fix resolution conflict between global and class static variables in C++.
Fix resolution conflict between global and class static variables in C++
Aug 18 2015, 3:48 PM
paulherman committed rL245380: Test chaned function calls and imported namespaces in C++.
Test chaned function calls and imported namespaces in C++
Aug 18 2015, 3:44 PM

Aug 17 2015

paulherman updated the diff for D12044: Fix resolution conflict between global and class static variables in C++..

I've changed the commit so that ParseVariableDIE now detects if a variable is static inside a class or struct. Now "target variable" works since the variables are not removed from the variable list of the compile unit, but filtered when searching for a specific variable.

Aug 17 2015, 3:05 PM

Aug 14 2015

paulherman added a reviewer for D12044: Fix resolution conflict between global and class static variables in C++.: chaoren.
Aug 14 2015, 5:10 PM
paulherman retitled D12044: Fix resolution conflict between global and class static variables in C++. from to Fix resolution conflict between global and class static variables in C/C++..
Aug 14 2015, 4:54 PM
paulherman added a comment to D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions..

This patch does exactly that. It detects the language of the frame and upgrades it according to the rules you said (I think I might've missed ObjC -> ObjC++, but that can be added).

Aug 14 2015, 1:47 PM

Aug 11 2015

paulherman added a comment to D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions..

The idea is that, as I user, I do not expect the identifiers "Class" and "id" to not be available - I don't think I've seen a warning or notice about that when evaluating expressions.

Aug 11 2015, 9:39 AM

Aug 5 2015

paulherman updated the diff for D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions..

Fix ObjC++ types Class and id being defined in C and C++ expressions.

Aug 5 2015, 4:26 PM
paulherman retitled D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions. from to Fix ObjC++ types Class and id being defined in C and C++ expressions..
Aug 5 2015, 4:22 PM
paulherman abandoned D11688: Fix ObjC types Class and id being defined in C and C++ expressions..
Aug 5 2015, 4:21 PM
paulherman updated the diff for D11688: Fix ObjC types Class and id being defined in C and C++ expressions..
  • Guess the language of the expression based on the execution context.
  • Tests for language guessing.
Aug 5 2015, 10:02 AM

Aug 3 2015

paulherman added a reviewer for D11688: Fix ObjC types Class and id being defined in C and C++ expressions.: jingham.
Aug 3 2015, 1:48 PM

Jul 31 2015

paulherman updated the diff for D11688: Fix ObjC types Class and id being defined in C and C++ expressions..

Update ClangASTSource constructor.

Jul 31 2015, 12:26 PM
paulherman retitled D11688: Fix ObjC types Class and id being defined in C and C++ expressions. from to Fix ObjC types Class and id being defined in C and C++ expressions..
Jul 31 2015, 11:51 AM

Jul 30 2015

paulherman added a comment to D11543: Fix evaluation of global operators in C++.

Sean, could you please have a look?

Jul 30 2015, 10:41 AM

Jul 27 2015

paulherman retitled D11543: Fix evaluation of global operators in C++ from to Fix evaluation of global operators in C++.
Jul 27 2015, 3:20 PM

Jul 15 2015

paulherman updated the diff for D11204: Test chained function calls in C++.
  • Test imported namespaces in C++
Jul 15 2015, 11:45 AM

Jul 14 2015

paulherman added a comment to D11204: Test chained function calls in C++.

The 2nd diff was meant to be a separate one.

Jul 14 2015, 4:34 PM
paulherman updated the diff for D11204: Test chained function calls in C++.
  • Test imported namespaces in C++
Jul 14 2015, 3:53 PM
paulherman retitled D11204: Test chained function calls in C++ from to Test chained function calls in C++.
Jul 14 2015, 3:43 PM