This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add a test for std::ssize's SFINAE
ClosedPublic

Authored by ldionne on Mar 7 2022, 1:05 PM.

Details

Reviewers
Quuxplusone
ldionne
Group Reviewers
Restricted Project
Commits
rG3df1a64ebad8: [libc++] Add a test for std::ssize's SFINAE
Summary

Inspired by https://reviews.llvm.org/D120684#inline-1157644 and subsequent LWG discussion.
See https://cplusplus.github.io/LWG/issue3207 for not-enough-background. :)

Wondering how to restrict this to run on just these weird 32-bit-ptrdiff_t/64-bit-pointer platforms, without running the risk of quietly nerfing the test forever and never noticing.

@ldionne, I wonder if there's a way to get buildkite to alert us about test files that have been skipped in all jobs. That would be generally useful.

Diff Detail

Event Timeline

Quuxplusone created this revision.Mar 7 2022, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2022, 1:05 PM
Quuxplusone requested review of this revision.Mar 7 2022, 1:05 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 7 2022, 1:05 PM
Quuxplusone retitled this revision from [libc++] Add a test for std::ssize's SFINAE. [WIP] to [libc++] Add a test for std::ssize's SFINAE.

Try a .sh.cpp test. This might be ready for review, although I assume I'll have to UNSUPPORTED a few platforms depending on what CI says.

ldionne commandeered this revision.Sep 5 2023, 12:50 PM
ldionne edited reviewers, added: Quuxplusone; removed: ldionne.

[Github PR transition cleanup]

Picking this up, I think the test is relevant.

ldionne updated this revision to Diff 555918.Sep 5 2023, 12:55 PM

Rebase, make into a .compile.pass.cpp test.

ldionne updated this revision to Diff 556025.Sep 6 2023, 6:38 AM

Don't hardcode -m32, instead only run the test on 32 bit platforms.

ldionne updated this revision to Diff 556040.Sep 6 2023, 7:57 AM

Poke CI.

ldionne accepted this revision.Sep 6 2023, 4:38 PM

CI passed, phab report step is broken.

This revision is now accepted and ready to land.Sep 6 2023, 4:38 PM
This revision was landed with ongoing or failed builds.Sep 6 2023, 4:42 PM
This revision was automatically updated to reflect the committed changes.