This is an archive of the discontinued LLVM Phabricator instance.

Differential D120563

[HIP] Fix test hip-link-bundled-archive.hip
ClosedPublic

Authored by yaxunl on Feb 25 2022, 6:02 AM.

Details

Reviewers
tra
shangwuyao
Commits
rGdf0c98364322: [HIP] Fix test hip-link-bundled-archive.hip
Summary

match pattern should match lld.exe on windows

Diff Detail

Event Timeline

yaxunl requested review of this revision.Feb 25 2022, 6:02 AM
yaxunl created this revision.
yaxunl mentioned this in D120529: Disable broken hip test on Windows.Feb 25 2022, 6:05 AM
Harbormaster completed remote builds in B151468: Diff 411395.Feb 25 2022, 6:35 AM
shangwuyao accepted this revision.Feb 25 2022, 10:04 AM

LGTM, thanks for fixing this.

This revision is now accepted and ready to land.Feb 25 2022, 10:04 AM
Closed by commit rGdf0c98364322: [HIP] Fix test hip-link-bundled-archive.hip (authored by yaxunl). · Explain WhyFeb 25 2022, 12:28 PM
This revision was automatically updated to reflect the committed changes.
yaxunl added a commit: rGdf0c98364322: [HIP] Fix test hip-link-bundled-archive.hip.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2022, 12:28 PM

Revision Contents

PathSize
clang/
test/
Driver/
4 lines

Diff 411496

clang/test/Driver/hip-link-bundle-archive.hip

// REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target // REQUIRES: clang-driver, x86-registered-target, amdgpu-registered-target
// RUN: touch %T/libhipBundled.a // RUN: touch %T/libhipBundled.a
// Check clang unbundle the archive and link them by lld. // Check clang unbundle the archive and link them by lld.
// RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \ // RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \
// RUN: -nogpulib %s -fgpu-rdc -L%T -lhipBundled \ // RUN: -nogpulib %s -fgpu-rdc -L%T -lhipBundled \
// RUN: 2>&1 | FileCheck -check-prefix=CHECK %s // RUN: 2>&1 | FileCheck -check-prefix=CHECK %s
// CHECK: "{{.*}}clang-offload-bundler" "-unbundle" "-type=a" "-inputs={{.*}}libhipBundled.a" "-targets=hip-amdgcn-amd-amdhsa-gfx1030" "-outputs=[[A1030:.*\.a]]" "-allow-missing-bundles" // CHECK: "{{.*}}clang-offload-bundler" "-unbundle" "-type=a" "-inputs={{.*}}libhipBundled.a" "-targets=hip-amdgcn-amd-amdhsa-gfx1030" "-outputs=[[A1030:.*\.a]]" "-allow-missing-bundles"
// CHECK: "{{.*}}lld" {{.*}}"-plugin-opt=mcpu=gfx1030" {{.*}} "[[A1030]]" // CHECK: "{{.*}}lld{{.*}}" {{.*}}"-plugin-opt=mcpu=gfx1030" {{.*}} "[[A1030]]"
// CHECK: "{{.*}}clang-offload-bundler" "-unbundle" "-type=a" "-inputs={{.*}}libhipBundled.a" "-targets=hip-amdgcn-amd-amdhsa-gfx906" "-outputs=[[A906:.*\.a]]" "-allow-missing-bundles" // CHECK: "{{.*}}clang-offload-bundler" "-unbundle" "-type=a" "-inputs={{.*}}libhipBundled.a" "-targets=hip-amdgcn-amd-amdhsa-gfx906" "-outputs=[[A906:.*\.a]]" "-allow-missing-bundles"
// CHECK: "{{.*}}lld" {{.*}}"-plugin-opt=mcpu=gfx906" {{.*}} "[[A906]]" // CHECK: "{{.*}}lld{{.*}}" {{.*}}"-plugin-opt=mcpu=gfx906" {{.*}} "[[A906]]"