This is an archive of the discontinued LLVM Phabricator instance.

Add a little test for simple breaking on overloaded functions by name
ClosedPublic

Authored by jingham on Feb 16 2022, 5:54 PM.

Details

Reviewers
JDevlieghere
Summary

When Jonas made the change to not add demangled names to the name indexes, we were worried it might cause breaking on overloaded functions to stop working. But that's actually not true, anything that uses the Symbol::LookupInfo to search names will do the right thing here, which includes SBModule::FindFunctions and the breakpoint by name resolver. That does the job of extracting the base name, finding potential matches, and then comparing the demangled name of the match to the input string. It's still the case that the names must match exactly.

Anyway, in the course of proving this to myself I wrote a little test for simple overloaded name breakpoints.

Diff Detail

Event Timeline

jingham requested review of this revision.Feb 16 2022, 5:54 PM
jingham created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2022, 5:54 PM
JDevlieghere accepted this revision.Feb 16 2022, 5:55 PM

Thanks Jim! LGTM

This revision is now accepted and ready to land.Feb 16 2022, 5:55 PM

Should have been Module::LookupInfo in the Description...

This was submitted (dd8490d207d3a1612091abbea04bf660f133a89f) but I neglected to put the "Differential Revision" tag in the commit message so automation didn't pick that up...

Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 11:14 AM
JDevlieghere closed this revision.Apr 29 2022, 3:44 PM