Page MenuHomePhabricator

Represent 2 parallel string arrays as one string[][2] array.
ClosedPublic

Authored by dougk on Aug 12 2015, 1:59 PM.

Details

Summary

I think this conveys the intent better. Alternatively, since it's effectively trying to take llvm::sys::path::parent_path() for a number of times determined by the occurrences of '/' in one string, we could just do that without storing the string of dot-dot-slashes although syntactic processing of pathnames is not quite the same as semantic processing (via the actual filesystem).

Diff Detail

Repository
rL LLVM

Event Timeline

dougk updated this revision to Diff 31977.Aug 12 2015, 1:59 PM
dougk retitled this revision from to Represent 2 parallel string arrays as one string[][2] array..
dougk updated this object.
dougk added a reviewer: chandlerc.
dougk added a subscriber: cfe-commits.
jyknight accepted this revision.Aug 14 2015, 8:34 AM
jyknight edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2015, 8:34 AM
This revision was automatically updated to reflect the committed changes.