This is an archive of the discontinued LLVM Phabricator instance.

Differential D119263

[libc++][nfc] Use TEST_HAS_NO_WIDE_CHARACTERS.
ClosedPublic

Authored by Mordante on Feb 8 2022, 10:23 AM.

Details

Reviewers
• Quuxplusone
Group Reviewers
Restricted Project
Commits
rGd9d2ebbfcb20: [libc++][nfc] Use TEST_HAS_NO_WIDE_CHARACTERS.
Summary

This avoids using an libc++ internal macro in our tests.

Diff Detail

Event Timeline

Mordante requested review of this revision.Feb 8 2022, 10:23 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2022, 10:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
• Quuxplusone accepted this revision.Feb 8 2022, 11:19 AM
• Quuxplusone added a subscriber: • Quuxplusone.
• Quuxplusone added inline comments.
libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/default.pass.cpp
63–65

I blame clang-format for this confusingly indented code. :yuck:

This revision is now accepted and ready to land.Feb 8 2022, 11:19 AM
Harbormaster completed remote builds in B148295: Diff 406888.Feb 8 2022, 12:51 PM
Mordante marked an inline comment as done.Feb 9 2022, 8:09 AM

thanks for the review.

libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/default.pass.cpp
63–65

clang-format agrees with you ;-) I'll commit the formatted version.

Closed by commit rGd9d2ebbfcb20: [libc++][nfc] Use TEST_HAS_NO_WIDE_CHARACTERS. (authored by Mordante). · Explain WhyFeb 9 2022, 8:10 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.
Mordante added a commit: rGd9d2ebbfcb20: [libc++][nfc] Use TEST_HAS_NO_WIDE_CHARACTERS..

Revision Contents

PathSize
libcxx/
test/
std/
input.output/
string.streams/
istringstream/
istringstream.cons/
2 lines
ostringstream/
ostringstream.cons/
2 lines
stringstream.cons/
2 lines

Diff 407163

libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/default.pass.cpp

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines#ifndef TEST_HAS_NO_WIDE_CHARACTERS
assert(ss.rdbuf() != 0); assert(ss.rdbuf() != 0);
assert(ss.good()); assert(ss.good());
assert(ss.str() == L""); assert(ss.str() == L"");
} }
#endif #endif
#if TEST_STD_VER >= 11 #if TEST_STD_VER >= 11
test<std::istringstream>(); test<std::istringstream>();
# ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS # ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::wistringstream>(); test<std::wistringstream>();
# endif # endif
QuuxplusoneUnsubmitted
Done
ReplyInline Actions

I blame clang-format for this confusingly indented code. :yuck:

Quuxplusone: I blame clang-format for this confusingly indented code. :yuck:
MordanteAuthorUnsubmitted
Done
ReplyInline Actions

clang-format agrees with you ;-) I'll commit the formatted version.

Mordante: clang-format agrees with you ;-) I'll commit the formatted version.
#endif #endif
return 0; return 0;
} }

libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/default.pass.cpp

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines#ifndef TEST_HAS_NO_WIDE_CHARACTERS
assert(ss.rdbuf() != 0); assert(ss.rdbuf() != 0);
assert(ss.good()); assert(ss.good());
assert(ss.str() == L""); assert(ss.str() == L"");
} }
#endif // TEST_HAS_NO_WIDE_CHARACTERS #endif // TEST_HAS_NO_WIDE_CHARACTERS
#if TEST_STD_VER >= 11 #if TEST_STD_VER >= 11
test<std::ostringstream>(); test<std::ostringstream>();
# ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS # ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::wostringstream>(); test<std::wostringstream>();
# endif # endif
#endif #endif
return 0; return 0;
} }

libcxx/test/std/input.output/string.streams/stringstream.cons/default.pass.cpp

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines#ifndef TEST_HAS_NO_WIDE_CHARACTERS
assert(ss.rdbuf() != 0); assert(ss.rdbuf() != 0);
assert(ss.good()); assert(ss.good());
assert(ss.str() == L""); assert(ss.str() == L"");
} }
#endif #endif
#if TEST_STD_VER >= 11 #if TEST_STD_VER >= 11
test<std::stringstream>(); test<std::stringstream>();
# ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS # ifndef TEST_HAS_NO_WIDE_CHARACTERS
test<std::wstringstream>(); test<std::wstringstream>();
# endif # endif
#endif #endif
return 0; return 0;
} }