Page MenuHomePhabricator

[dllimport] A non-imported class with an imported key can't have a key
ClosedPublic

Authored by rnk on Aug 10 2015, 11:19 AM.

Details

Summary

The vtable takes its DLL storage class from the class, not the key
function. When they disagree, the vtable won't be exported by the DLL
that defines the key function. The easiest way to ensure that importers
of the class emit their own vtable is to say that the class has no key
function.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk updated this revision to Diff 31697.Aug 10 2015, 11:19 AM
rnk retitled this revision from to [dllimport] A non-imported class with an imported key can't have a key.
rnk updated this object.
rnk added reviewers: majnemer, hans.
rnk added a subscriber: cfe-commits.
majnemer accepted this revision.Aug 10 2015, 11:34 AM
majnemer edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 10 2015, 11:34 AM
This revision was automatically updated to reflect the committed changes.