This is an archive of the discontinued LLVM Phabricator instance.

Differential D118959

[libclc][cmake] Support custom GNU install dirs
Needs ReviewPublic

Authored by r-burns on Feb 3 2022, 6:09 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Custom GNU install dirs specified at configure time may be absolute paths, in which case appending to the install prefix is not correct. Instead we can use the already available CMAKE_INSTALL_FULL_* variables, which are correctly precomputed absolute paths.

This is helpful in Nixpkgs, where we specify an absolute CMAKE_INSTALL_INCLUDEDIR by default. Also, this may resolve the issue that prompted https://reviews.llvm.org/D111111

Diff Detail

Event Timeline

r-burns created this revision.Feb 3 2022, 6:09 PM
Herald added a subscriber: jvesely. · View Herald TranscriptFeb 3 2022, 6:09 PM
r-burns requested review of this revision.Feb 3 2022, 6:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2022, 6:09 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B147542: Diff 405843.Feb 3 2022, 6:43 PM

Revision Contents

PathSize
libclc/
4 lines

Diff 405843

libclc/libclc.pc.in

includedir=@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_INCLUDEDIR@ includedir=@CMAKE_INSTALL_FULL_INCLUDEDIR@
libexecdir=@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_DATADIR@/clc libexecdir=@CMAKE_INSTALL_FULL_DATADIR@/clc
Name: libclc Name: libclc
Description: Library requirements of the OpenCL C programming language Description: Library requirements of the OpenCL C programming language