This is an archive of the discontinued LLVM Phabricator instance.

Update Symbolize dependencies in bazel build file.
AcceptedPublic

Authored by cmtice on Feb 3 2022, 4:47 PM.

Details

Reviewers
GMNGeoffrey
Summary

Some of the profiling code now depends on Symbolize, and the dependencies in the bazel build need to be updated appropriately.

Diff Detail

Event Timeline

cmtice requested review of this revision.Feb 3 2022, 4:47 PM
cmtice created this revision.
cmtice added a reviewer: GMNGeoffrey.
GMNGeoffrey accepted this revision.Feb 3 2022, 4:55 PM

Seems like the relevant patch was reverted? https://github.com/llvm/llvm-project/commit/dbf47d227d080e4eb7239b589660f51d7b08afa9 -> https://buildkite.com/llvm-project/upstream-bazel-rbe/builds/19349. Probably good to keep this around anyway, since I suspect it will be re-landed at some point. This looks like a reasonable fix for that, so I'll go ahead and approve, but if you need to land again, please rebase and wait for pre-merge checks to pass (for some reason they're taking a while on this commit).

This revision is now accepted and ready to land.Feb 3 2022, 4:55 PM