This is an archive of the discontinued LLVM Phabricator instance.

Differential D118360

[NFC][cmake] Respect LLVM_ENABLE_TERMINFO when building llvm-config
Needs ReviewPublic

Authored by andrew-wja on Jan 27 2022, 6:15 AM.

Details

Reviewers
mgorny
Summary

llvm-config currently ignores LLVM_ENABLE_TERMINFO and always passes -ltinfo when linking the executable.

This currently breaks cross-compilation of LLVM for a target system without a native libtinfo available, which is not ideal.

This patch simply removes -ltinfo from the llvm-config link line if LLVM_ENABLE_TERMINFO is false.

Diff Detail

Unit TestsFailed

TimeTest
1,250 msx64 debian > libarcher.races::critical-unrelated.c
1,330 msx64 debian > libarcher.races::lock-nested-unrelated.c
1,290 msx64 debian > libarcher.races::lock-unrelated.c
1,380 msx64 debian > libarcher.races::parallel-simple.c
2,110 msx64 debian > libarcher.races::task-dependency.c
View Full Test Results (9 Failed)

Event Timeline

andrew-wja requested review of this revision.Jan 27 2022, 6:15 AM
andrew-wja created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2022, 6:15 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B146010: Diff 403628.Jan 27 2022, 11:17 AM
mgorny added a comment.Feb 11 2022, 2:53 AM

Please upload patches generated with -U9999, so that Phabricator has the complete context to show.

mgorny added a comment.Feb 11 2022, 2:55 AM

That said, I'm sorry but I'm confused. Could you explain in greater detail what are you doing? llvm-config doesn't sound like something you should use for cross-compiling.

Revision Contents

PathSize
llvm/
tools/
llvm-config/
5 lines

Diff 403628

llvm/tools/llvm-config/CMakeLists.txt

Context not available.
endforeach() endforeach()
string(REPLACE ";" " " SYSTEM_LIBS "${SYSTEM_LIBS}") string(REPLACE ";" " " SYSTEM_LIBS "${SYSTEM_LIBS}")
# Respect LLVM_ENABLE_TERMINFO
if(NOT ${LLVM_ENABLE_TERMINFO})
string(REPLACE "-ltinfo" "" SYSTEM_LIBS "${SYSTEM_LIBS}")
endif()
# Fetch target specific compile options, e.g. RTTI option # Fetch target specific compile options, e.g. RTTI option
get_property(COMPILE_FLAGS TARGET llvm-config PROPERTY COMPILE_FLAGS) get_property(COMPILE_FLAGS TARGET llvm-config PROPERTY COMPILE_FLAGS)
Context not available.