This is an archive of the discontinued LLVM Phabricator instance.

[test][NewGVN] Use -passes=newgvn instead of -newgvn
ClosedPublic

Authored by bjope on Jan 27 2022, 2:54 AM.

Details

Summary

Use the new PM syntax when specifying the pipeline in regression
tests previously running

"opt -newgvn ..."

Instead we now do

"opt -passes=newgvn ..."

Notice that this also changes the aa-pipeline to become the default
aa-pipeline instead of just basic-aa. Since these tests haven't been
explicitly requesting basic-aa in the past (compared to the test cases
updated in a separate patch involving "-basic-aa -newgvn") it is
assumed that the exact aa-pipeline isn't important for the validity
of the test cases. An alternative could have been to add
-aa-pipeline=basic-aa as well to the run lines, but that might just
add clutter in case the test cases do not care about the aa-pipeline.

This is another step to move away from the legacy PM syntax when
specifying passes in opt.

Diff Detail

Event Timeline

bjope requested review of this revision.Jan 27 2022, 2:54 AM
bjope created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2022, 2:54 AM
fhahn added a subscriber: fhahn.Jan 27 2022, 2:58 AM
fhahn added inline comments.
llvm/test/Transforms/NewGVN/opt-remarks-xfail.ll
2

this is now redundant?

llvm/test/Transforms/NewGVN/pr32403.ll
2

tiniest nit: while you are here, also add a space after ;?

llvm/test/Transforms/NewGVN/pr33014.ll
2

While you are here, maybe also drop REQUIRES; asserts? The test checks for the full IR output and no debug output, so there's no need for assertions.

bjope updated this revision to Diff 403608.Jan 27 2022, 4:59 AM

Updated based on review feedback.

bjope marked 3 inline comments as done.Jan 28 2022, 4:06 AM
fhahn accepted this revision.Jan 28 2022, 4:10 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 28 2022, 4:10 AM
This revision was landed with ongoing or failed builds.Jan 28 2022, 4:58 AM
This revision was automatically updated to reflect the committed changes.