review revisions

clang/lib/Format/UnwrappedLineFormatter.cpp

private:
   ///
   /// For example, 'public:' labels in classes are offset by 1 or 2
   /// characters to the left from their level.
   int getIndentOffset(const FormatToken &RootToken) {
     if (Style.Language == FormatStyle::LK_Java || Style.isJavaScript() ||
         Style.isCSharp())
       return 0;
 
-    auto isAccessModifier = [this, &RootToken]() {
-      bool returnValue{false};
-      if (RootToken.isAccessSpecifier(Style.isCpp())) {
-        returnValue = true;
-      } else if (RootToken.isObjCAccessSpecifier()) {
-        returnValue = true;
-      }
+    auto IsAccessModifier = [this, &RootToken]() {
+      if (RootToken.isAccessSpecifier(Style.isCpp()))
+        return true;
+      else if (RootToken.isObjCAccessSpecifier())
+        return true;
       // Handle Qt signals
       else if ((RootToken.isOneOf(Keywords.kw_signals, Keywords.kw_qsignals) &&
-                RootToken.Next && RootToken.Next->is(tok::colon))) {
-        returnValue = true;
-      }
+                RootToken.Next && RootToken.Next->is(tok::colon)))
+        return true;
       // Handle malformed access specifier i.e. 'private' without trailing ':'
       else if ((RootToken.isAccessSpecifier(false) &&
                 (!RootToken.Next ||
-                 (C_OperatorsFollowingVar.find(RootToken.Next->Tok.getKind()) ==
-                      clang::format::C_OperatorsFollowingVar.end() &&
-                  !RootToken.Next->Tok.is(tok::coloncolon))))) {
-        returnValue = true;
-      }
-      return returnValue;
+                 (!C_OperatorsFollowingVar.count(
+                      RootToken.Next->Tok.getKind()) &&
+                  !RootToken.Next->Tok.is(tok::coloncolon)))))
+        return true;
+      return false;
     };
 
-    if (isAccessModifier()) {
+    if (IsAccessModifier()) {
       // The AccessModifierOffset may be overridden by IndentAccessModifiers,
       // in which case we take a negative value of the IndentWidth to simulate
       // the upper indent level.
       return Style.IndentAccessModifiers ? -Style.IndentWidth
                                          : Style.AccessModifierOffset;
     }
     return 0;
   }

clang/lib/Format/UnwrappedLineParser.cpp

if (FormatTok->Tok.is(tok::l_brace)) {
     addUnwrappedLine();
     ++Line->Level;
     parseStructuralElement();
     --Line->Level;
   }
 }
 
 void UnwrappedLineParser::parseAccessSpecifier() {
-  auto *accessSpecifierCandidate = FormatTok;
+  auto *AccessSpecifierCandidate = FormatTok;
   nextToken();
   // Understand Qt's slots.
   if (FormatTok->isOneOf(Keywords.kw_slots, Keywords.kw_qslots))
     nextToken();
   // Otherwise, we don't know what it is, and we'd better keep the next token.
   if (FormatTok->Tok.is(tok::colon)) {
     nextToken();
     addUnwrappedLine();
     // is not a variable name or namespacename
-  } else if (C_OperatorsFollowingVar.find(FormatTok->Tok.getKind()) ==
-                 C_OperatorsFollowingVar.end() &&
-             !FormatTok->Tok.is(tok::coloncolon)) {
+  } else if (!C_OperatorsFollowingVar.count(FormatTok->Tok.getKind()) &&
+             !FormatTok->Tok.is(tok::coloncolon))
     addUnwrappedLine();
-  }
   // consider the accessSpecifier to be a C identifier
-  else if (accessSpecifierCandidate) {
-    accessSpecifierCandidate->Tok.setKind(tok::identifier);
-  }
+  else if (AccessSpecifierCandidate)
+    AccessSpecifierCandidate->Tok.setKind(tok::identifier);
 }
 
 void UnwrappedLineParser::parseConcept() {
   assert(FormatTok->Tok.is(tok::kw_concept) && "'concept' expected");
   nextToken();
   if (!FormatTok->Tok.is(tok::identifier))
     return;
   nextToken();