In D117416#3282937, @HazardyKnusperkeks wrote:

In D117416#3282853, @psigillito wrote:

Do I need to care about these pre-build checks failing?

The checks passed, the build on linux failed. But as far as I can see it's something in openmp. I assume you did run all the format tests, then everything should be fine.

Do I need to care about these pre-build checks failing?

@HazardyKnusperkeks
Ok thanks, someone else can commit on my behalf while I wait for commit access.

@HazardyKnusperkeks I do not have commit access. This is my first commit to the project. Do I just need to issue an 'arc land' command?

• unnecessary whitespace

• wrap vector in function

• review changes, lower_bound to binary_search

• revert auto formatting comments

• Merge branch 'main' of https://github.com/llvm/llvm-project
• code review syntax cleanup, sorted vector

• revert of .arclint file delete

• revert bad arclint changes

Base diff on upstream

undo arclint change

Review Changes

• revert bad changes and arclint

• revert to corner case handling with private

Ok, as I was starting to add a new language, the scope of changes just continued to grow.

These are just initial changes, there is still a lot of work and test cases to write. I figured I would put this out there to see if this is the direction we were thinking.

• annoying arc changes

• undo delete

Include multiple commits in review

Hopefully this revision works

revert changes

Removed old approach and started initial changes to add C language

In D117416#3246838, @curdeius wrote:

Thanks for having a try on this.
However, I don't like this approach too much. You add many changes and a single test. That's not sufficient.
Also, handling C++ keywords in all cases (e.g. delete as a function name) *may* need to distinguish whether we format a C file or a C++ file. It's probably impossible to do this without user input (.h extension is used in both languages for example).
We'd maybe need to add C as language option and let the user specify the language (-x c?).
That in turn may be painful (because not automatic).
But, you may have a better solution.
My 2 cents.

Sorry, this is my first time using Phabricator. I am not sure if it matters that .arclint is changed in this review, it is not part of my commit.