Page MenuHomePhabricator

psigillito (psigillito)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2022, 1:03 PM (18 w, 10 h)

Recent Activity

Jan 30 2022

psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Do I need to care about these pre-build checks failing?

The checks passed, the build on linux failed. But as far as I can see it's something in openmp. I assume you did run all the format tests, then everything should be fine.

Jan 30 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Do I need to care about these pre-build checks failing?

Jan 30 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

@HazardyKnusperkeks
Ok thanks, someone else can commit on my behalf while I wait for commit access.

Jan 30 2022, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

@HazardyKnusperkeks I do not have commit access. This is my first commit to the project. Do I just need to issue an 'arc land' command?

Jan 30 2022, 6:28 AM · Restricted Project, Restricted Project, Restricted Project

Jan 29 2022

psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • unnecessary whitespace
Jan 29 2022, 7:19 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • wrap vector in function
Jan 29 2022, 7:12 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • review changes, lower_bound to binary_search
Jan 29 2022, 10:34 AM · Restricted Project, Restricted Project, Restricted Project
psigillito added inline comments to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
Jan 29 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2022

psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • revert auto formatting comments
Jan 27 2022, 7:37 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
Jan 27 2022, 7:22 PM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2022

psigillito added inline comments to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
Jan 26 2022, 8:33 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2022

psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • revert of .arclint file delete
Jan 24 2022, 7:23 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • revert bad arclint changes
Jan 24 2022, 7:14 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Base diff on upstream

Jan 24 2022, 7:08 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

undo arclint change

Jan 24 2022, 6:57 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Review Changes

Jan 24 2022, 6:41 PM · Restricted Project, Restricted Project, Restricted Project
psigillito requested review of D118092: review revisions.
Jan 24 2022, 6:39 PM · Restricted Project

Jan 21 2022

psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • revert bad changes and arclint
Jan 21 2022, 5:49 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • revert to corner case handling with private
Jan 21 2022, 5:13 PM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2022

psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Ok, as I was starting to add a new language, the scope of changes just continued to grow.

Jan 18 2022, 8:27 PM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2022

psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

These are just initial changes, there is still a lot of work and test cases to write. I figured I would put this out there to see if this is the direction we were thinking.

Jan 17 2022, 10:28 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • annoying arc changes
Jan 17 2022, 10:26 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
  • undo delete
Jan 17 2022, 10:22 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Include multiple commits in review

Jan 17 2022, 10:19 PM · Restricted Project, Restricted Project, Restricted Project
psigillito requested review of D117536: Handle C variables with name that matches c++ access specifier.
Jan 17 2022, 10:18 PM · Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Hopefully this revision works

Jan 17 2022, 9:54 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

revert changes

Jan 17 2022, 9:21 PM · Restricted Project, Restricted Project, Restricted Project
psigillito updated the diff for D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Removed old approach and started initial changes to add C language

Jan 17 2022, 9:09 PM · Restricted Project, Restricted Project, Restricted Project
psigillito requested review of D117532: revert arclint changes.
Jan 17 2022, 9:01 PM · Restricted Project

Jan 16 2022

psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Thanks for having a try on this.
However, I don't like this approach too much. You add many changes and a single test. That's not sufficient.
Also, handling C++ keywords in all cases (e.g. delete as a function name) *may* need to distinguish whether we format a C file or a C++ file. It's probably impossible to do this without user input (.h extension is used in both languages for example).
We'd maybe need to add C as language option and let the user specify the language (-x c?).
That in turn may be painful (because not automatic).
But, you may have a better solution.
My 2 cents.

Jan 16 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

Jan 15 2022

psigillito abandoned D117415: Handle C variables with name that matches c++ access specifier.
Jan 15 2022, 9:19 PM · Restricted Project
psigillito added a comment to D117416: [clang-format] Handle C variables with name that matches c++ access specifier.

Sorry, this is my first time using Phabricator. I am not sure if it matters that .arclint is changed in this review, it is not part of my commit.

Jan 15 2022, 8:46 PM · Restricted Project, Restricted Project, Restricted Project
psigillito added reviewers for D117416: [clang-format] Handle C variables with name that matches c++ access specifier: MyDeveloperDay, curdeius, owenpan.
Jan 15 2022, 8:31 PM · Restricted Project, Restricted Project, Restricted Project
psigillito requested review of D117416: [clang-format] Handle C variables with name that matches c++ access specifier.
Jan 15 2022, 8:23 PM · Restricted Project, Restricted Project, Restricted Project
psigillito requested review of D117415: Handle C variables with name that matches c++ access specifier.
Jan 15 2022, 8:08 PM · Restricted Project