This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC
ClosedPublic

Authored by CaseyCarter on Jan 22 2022, 12:50 PM.

Details

Summary

<meme>How many layers of irony are you on?</meme>

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 22 2022, 12:50 PM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 22 2022, 12:50 PM
Mordante accepted this revision as: Mordante.Jan 23 2022, 4:33 AM
Mordante added a subscriber: Mordante.

Just imagine what this test does to MSVC STL's test coverage ;-)

LGTM!

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2022, 10:13 AM
This revision was automatically updated to reflect the committed changes.