This is an archive of the discontinued LLVM Phabricator instance.

Differential D117967

[libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC
ClosedPublic

Authored by CaseyCarter on Jan 22 2022, 12:50 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG818cfb10c574: [libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC
Summary

<meme>How many layers of irony are you on?</meme>

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 22 2022, 12:50 PM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 22 2022, 12:50 PM
Harbormaster completed remote builds in B145044: Diff 402255.Jan 22 2022, 4:56 PM
Mordante accepted this revision as: Mordante.Jan 23 2022, 4:33 AM
Mordante added a subscriber: Mordante.

Just imagine what this test does to MSVC STL's test coverage ;-)

LGTM!

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2022, 10:13 AM
Closed by commit rG818cfb10c574: [libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC (authored by CaseyCarter). · Explain Why
This revision was automatically updated to reflect the committed changes.
CaseyCarter added a commit: rG818cfb10c574: [libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC.

Revision Contents

PathSize
libcxx/
test/
std/
utilities/
charconv/
charconv.msvc/
5 lines

Diff 402350

libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp

Show All 25 Lines
#include <type_traits> #include <type_traits>
// Work-around for sprintf_s's usage in the Microsoft tests. // Work-around for sprintf_s's usage in the Microsoft tests.
#ifndef _WIN32 #ifndef _WIN32
# define sprintf_s snprintf # define sprintf_s snprintf
#endif #endif
#ifdef _MSVC_STL_VERSION
#include <xutility>
using std::_Bit_cast;
#else
// FUNCTION TEMPLATE _Bit_cast // FUNCTION TEMPLATE _Bit_cast
template <class _To, class _From, template <class _To, class _From,
std::enable_if_t<sizeof(_To) == sizeof(_From) && std::is_trivially_copyable_v<_To> && std::enable_if_t<sizeof(_To) == sizeof(_From) && std::is_trivially_copyable_v<_To> &&
std::is_trivially_copyable_v<_From>, std::is_trivially_copyable_v<_From>,
int> = 0> int> = 0>
[[nodiscard]] constexpr _To _Bit_cast(const _From& _From_obj) noexcept { [[nodiscard]] constexpr _To _Bit_cast(const _From& _From_obj) noexcept {
return __builtin_bit_cast(_To, _From_obj); return __builtin_bit_cast(_To, _From_obj);
} }
#endif
// Includes Microsoft's test that tests the entire header. // Includes Microsoft's test that tests the entire header.
#include "test.cpp" #include "test.cpp"