This is an archive of the discontinued LLVM Phabricator instance.

Differential D11794

Fix REPE, REPZ, REPNZ for intel syntax
ClosedPublic

Authored by myatsina on Aug 6 2015, 1:27 AM.

Details

Reviewers
mcrosier
Commits
rGd353c45eafd1: [X86] Fix REPE, REPZ, REPNZ for intel syntax
rL244584: [X86] Fix REPE, REPZ, REPNZ for intel syntax
Summary

Fix REPE, REPZ, REPNZ for intel syntax

Diff Detail

Repository
rL LLVM

Event Timeline

myatsina updated this revision to Diff 31355.Aug 6 2015, 1:27 AM
myatsina retitled this revision from to Fix REPE, REPZ, REPNZ for intel syntax.
myatsina updated this object.
myatsina added a reviewer: mcrosier.
myatsina set the repository for this revision to rL LLVM.
myatsina added a subscriber: llvm-commits.
myatsina updated this revision to Diff 31436.Aug 6 2015, 3:40 AM

removed "rep" case from the test

mcrosier edited edge metadata.Aug 6 2015, 6:04 AM

And by fix you mean we should be applying the mnemonic aliases for both the Intel and
AT&T dialect unconditionally?

test/MC/X86/intel-syntax.s
7

Please put spaces between "//" and the "CHECK".

myatsina updated this revision to Diff 31614.Aug 9 2015, 1:40 AM
myatsina edited edge metadata.

Added space between '//' and 'CHECK:'

myatsina added a comment.Aug 9 2015, 1:43 AM

REPE, REPZ, REPNZ, REPNE should have mnemonics for Intel syntax as well.
Currently using these instructions causes compilation errors for Intel syntax.

mcrosier accepted this revision.Aug 10 2015, 6:33 AM
mcrosier edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 10 2015, 6:33 AM
Closed by commit rL244584: [X86] Fix REPE, REPZ, REPNZ for intel syntax (authored by myatsina). · Explain WhyAug 11 2015, 4:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
X86/
X86InstrInfo.td
X86InstrInfo.td (revision 243978)
6 lines
test/
MC/
X86/
intel-syntax.s
intel-syntax.s (revision 243978)
16 lines

Diff 31355

lib/Target/X86/X86InstrInfo.td

Show First 20 Lines • Show All 2,534 Lines • ▼ Show 20 Lines
def : MnemonicAlias<"popa", "popal", "intel">, Requires<[In32BitMode]>; def : MnemonicAlias<"popa", "popal", "intel">, Requires<[In32BitMode]>;
def : MnemonicAlias<"pusha", "pushal", "intel">, Requires<[In32BitMode]>; def : MnemonicAlias<"pusha", "pushal", "intel">, Requires<[In32BitMode]>;
def : MnemonicAlias<"popa", "popaw", "att">, Requires<[In16BitMode]>; def : MnemonicAlias<"popa", "popaw", "att">, Requires<[In16BitMode]>;
def : MnemonicAlias<"pusha", "pushaw", "att">, Requires<[In16BitMode]>; def : MnemonicAlias<"pusha", "pushaw", "att">, Requires<[In16BitMode]>;
def : MnemonicAlias<"popa", "popal", "att">, Requires<[In32BitMode]>; def : MnemonicAlias<"popa", "popal", "att">, Requires<[In32BitMode]>;
def : MnemonicAlias<"pusha", "pushal", "att">, Requires<[In32BitMode]>; def : MnemonicAlias<"pusha", "pushal", "att">, Requires<[In32BitMode]>;
def : MnemonicAlias<"repe", "rep", "att">; def : MnemonicAlias<"repe", "rep">;
def : MnemonicAlias<"repz", "rep", "att">; def : MnemonicAlias<"repz", "rep">;
def : MnemonicAlias<"repnz", "repne", "att">; def : MnemonicAlias<"repnz", "repne">;
def : MnemonicAlias<"ret", "retw", "att">, Requires<[In16BitMode]>; def : MnemonicAlias<"ret", "retw", "att">, Requires<[In16BitMode]>;
def : MnemonicAlias<"ret", "retl", "att">, Requires<[In32BitMode]>; def : MnemonicAlias<"ret", "retl", "att">, Requires<[In32BitMode]>;
def : MnemonicAlias<"ret", "retq", "att">, Requires<[In64BitMode]>; def : MnemonicAlias<"ret", "retq", "att">, Requires<[In64BitMode]>;
def : MnemonicAlias<"salb", "shlb", "att">; def : MnemonicAlias<"salb", "shlb", "att">;
def : MnemonicAlias<"salw", "shlw", "att">; def : MnemonicAlias<"salw", "shlw", "att">;
def : MnemonicAlias<"sall", "shll", "att">; def : MnemonicAlias<"sall", "shll", "att">;
▲ Show 20 Lines • Show All 397 Lines • Show Last 20 Lines

test/MC/X86/intel-syntax.s

// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel %s | FileCheck %s // RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel %s | FileCheck %s
_test: _test:
xor EAX, EAX xor EAX, EAX
ret ret
_main: _main:
mcrosierUnsubmitted
Not Done
ReplyInline Actions

Please put spaces between "//" and the "CHECK".

mcrosier: Please put spaces between "//" and the "CHECK".
// CHECK: movl $257, -4(%rsp) // CHECK: movl $257, -4(%rsp)
mov DWORD PTR [RSP - 4], 257 mov DWORD PTR [RSP - 4], 257
// CHECK: movl $258, 4(%rsp) // CHECK: movl $258, 4(%rsp)
mov DWORD PTR [RSP + 4], 258 mov DWORD PTR [RSP + 4], 258
// CHECK: movq $123, -16(%rsp) // CHECK: movq $123, -16(%rsp)
mov QWORD PTR [RSP - 16], 123 mov QWORD PTR [RSP - 16], 123
// CHECK: movb $97, -17(%rsp) // CHECK: movb $97, -17(%rsp)
mov BYTE PTR [RSP - 17], 97 mov BYTE PTR [RSP - 17], 97
▲ Show 20 Lines • Show All 660 Lines • ▼ Show 20 Lines
// CHECK: insl %dx, %es:(%rdi) // CHECK: insl %dx, %es:(%rdi)
outsb outsb
outsw outsw
outsd outsd
// CHECK: outsb (%rsi), %dx // CHECK: outsb (%rsi), %dx
// CHECK: outsw (%rsi), %dx // CHECK: outsw (%rsi), %dx
// CHECK: outsl (%rsi), %dx // CHECK: outsl (%rsi), %dx
rep cmpsb
repe cmpsb
repz cmpsb
repne cmpsb
repnz cmpsb
//CHECK: rep
//CHECK: cmpsb %es:(%rdi), (%rsi)
//CHECK: rep
//CHECK: cmpsb %es:(%rdi), (%rsi)
//CHECK: rep
//CHECK: cmpsb %es:(%rdi), (%rsi)
//CHECK: repne
//CHECK: cmpsb %es:(%rdi), (%rsi)
//CHECK: repne
//CHECK: cmpsb %es:(%rdi), (%rsi)