This is an archive of the discontinued LLVM Phabricator instance.

Allow ValueObject::Dereference to dereference references.
ClosedPublic

Authored by chaoren on Jul 30 2015, 3:52 PM.

Download Raw Diff

Details

Reviewers

Commits

rGd7bdc27b121e: Allow ValueObject::Dereference to dereference references.
rLLDB243716: Allow ValueObject::Dereference to dereference references.
rL243716: Allow ValueObject::Dereference to dereference references.

Diff Detail

Event Timeline

chaoren updated this revision to Diff 31084.Jul 30 2015, 3:52 PM

chaoren retitled this revision from to Allow ValueObject::Dereference to dereference references..

chaoren updated this object.

chaoren added a reviewer: clayborg.

chaoren added a subscriber: lldb-commits.

Looks fine.

This revision is now accepted and ready to land.Jul 30 2015, 5:34 PM

Closed by commit rL243716: Allow ValueObject::Dereference to dereference references. (authored by chaoren). · Explain WhyJul 30 2015, 5:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

source/

Core/

ValueObject.cpp

12 lines

Diff 31084

source/Core/ValueObject.cpp

Show First 20 Lines • Show All 3,705 Lines • ▼ Show 20 Lines	ValueObject::GetCPPVTableAddress (AddressType &address_type)
return LLDB_INVALID_ADDRESS;		return LLDB_INVALID_ADDRESS;
}		}

ValueObjectSP		ValueObjectSP
ValueObject::Dereference (Error &error)		ValueObject::Dereference (Error &error)
{		{
if (m_deref_valobj)		if (m_deref_valobj)
return m_deref_valobj->GetSP();		return m_deref_valobj->GetSP();

const bool is_pointer_type = IsPointerType();		const bool is_pointer_or_reference_type = IsPointerOrReferenceType();
if (is_pointer_type)		if (is_pointer_or_reference_type)
{		{
bool omit_empty_base_classes = true;		bool omit_empty_base_classes = true;
bool ignore_array_bounds = false;		bool ignore_array_bounds = false;

std::string child_name_str;		std::string child_name_str;
uint32_t child_byte_size = 0;		uint32_t child_byte_size = 0;
int32_t child_byte_offset = 0;		int32_t child_byte_offset = 0;
uint32_t child_bitfield_bit_size = 0;		uint32_t child_bitfield_bit_size = 0;
uint32_t child_bitfield_bit_offset = 0;		uint32_t child_bitfield_bit_offset = 0;
bool child_is_base_class = false;		bool child_is_base_class = false;
bool child_is_deref_of_parent = false;		bool child_is_deref_of_parent = false;
const bool transparent_pointers = false;		const bool transparent_pointers = false;
ClangASTType clang_type = GetClangType();		ClangASTType clang_type = GetClangType();
ClangASTType child_clang_type;		ClangASTType child_clang_type;

ExecutionContext exe_ctx (GetExecutionContextRef());		ExecutionContext exe_ctx (GetExecutionContextRef());

child_clang_type = clang_type.GetChildClangTypeAtIndex (&exe_ctx,		child_clang_type = clang_type.GetChildClangTypeAtIndex (&exe_ctx,
0,		0,
transparent_pointers,		transparent_pointers,
omit_empty_base_classes,		omit_empty_base_classes,
ignore_array_bounds,		ignore_array_bounds,
child_name_str,		child_name_str,
child_byte_size,		child_byte_size,
child_byte_offset,		child_byte_offset,
Show All 26 Lines	if (m_deref_valobj)
error.Clear();		error.Clear();
return m_deref_valobj->GetSP();		return m_deref_valobj->GetSP();
}		}
else		else
{		{
StreamString strm;		StreamString strm;
GetExpressionPath(strm, true);		GetExpressionPath(strm, true);

if (is_pointer_type)		if (is_pointer_or_reference_type)
error.SetErrorStringWithFormat("dereference failed: (%s) %s", GetTypeName().AsCString("<invalid type>"), strm.GetString().c_str());		error.SetErrorStringWithFormat("dereference failed: (%s) %s", GetTypeName().AsCString("<invalid type>"), strm.GetString().c_str());
else		else
error.SetErrorStringWithFormat("not a pointer type: (%s) %s", GetTypeName().AsCString("<invalid type>"), strm.GetString().c_str());		error.SetErrorStringWithFormat("not a pointer or reference type: (%s) %s", GetTypeName().AsCString("<invalid type>"), strm.GetString().c_str());
return ValueObjectSP();		return ValueObjectSP();
}		}
}		}

ValueObjectSP		ValueObjectSP
ValueObject::AddressOf (Error &error)		ValueObject::AddressOf (Error &error)
{		{
if (m_addr_of_valobj_sp)		if (m_addr_of_valobj_sp)
▲ Show 20 Lines • Show All 517 Lines • Show Last 20 Lines