This is an archive of the discontinued LLVM Phabricator instance.

Differential D116228

[libc][NFC] fix variable name
ClosedPublic

Authored by michaelrj on Dec 23 2021, 10:42 AM.

Details

Reviewers
None
Commits
rG3e52096809eb: [libc][NFC] fix variable name
Summary

A variable was named in a way that doesn't match the format. This patch
renames it to match the format.

Diff Detail

Event Timeline

michaelrj created this revision.Dec 23 2021, 10:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 23 2021, 10:42 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Dec 23 2021, 10:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 23 2021, 10:42 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG3e52096809eb: [libc][NFC] fix variable name (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG3e52096809eb: [libc][NFC] fix variable name.
Harbormaster completed remote builds in B140524: Diff 396052.Dec 23 2021, 10:47 AM

Revision Contents

PathSize
libc/
src/
math/
generic/
6 lines

Diff 396053

libc/src/math/generic/logf.cpp

Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines if (xbits.uintval() < FPBits::MIN_NORMAL ||
// Normalize denormal inputs. // Normalize denormal inputs.
xbits.val *= 0x1.0p23f; xbits.val *= 0x1.0p23f;
m = -23; m = -23;
} }
m += xbits.get_exponent(); m += xbits.get_exponent();
// Set bits to 1.m // Set bits to 1.m
xbits.set_unbiased_exponent(0x7F); xbits.set_unbiased_exponent(0x7F);
int fIndex = xbits.get_mantissa() >> 16; int f_index = xbits.get_mantissa() >> 16;
FPBits f(xbits.val); FPBits f(xbits.val);
f.bits &= ~0x0000'FFFF; f.bits &= ~0x0000'FFFF;
double d = static_cast<float>(xbits) - static_cast<float>(f); double d = static_cast<float>(xbits) - static_cast<float>(f);
d *= ONE_OVER_F[fIndex]; d *= ONE_OVER_F[f_index];
double r = __llvm_libc::fputil::polyeval( double r = __llvm_libc::fputil::polyeval(
d, 0x1.0000000008169p+0, -0x1.0000004f78405p-1, 0x1.555654d2bc769p-2, d, 0x1.0000000008169p+0, -0x1.0000004f78405p-1, 0x1.555654d2bc769p-2,
-0x1.00a570d090322p-2, 0x1.e158d823f89cap-3); -0x1.00a570d090322p-2, 0x1.e158d823f89cap-3);
double extra_factor = double extra_factor =
__llvm_libc::fputil::fma(static_cast<double>(m), LOG_2, LOG_F[fIndex]); __llvm_libc::fputil::fma(static_cast<double>(m), LOG_2, LOG_F[f_index]);
switch (FPBits(x).uintval()) { switch (FPBits(x).uintval()) {
case 0x3f80d19f: case 0x3f80d19f:
return 0x1.a1e82cp-8f; return 0x1.a1e82cp-8f;
case 0x41178feb: case 0x41178feb:
return 0x1.1fcbcep+1f; return 0x1.1fcbcep+1f;
case 0x4c5d65a5: case 0x4c5d65a5:
return 0x1.1e0696p+4f; return 0x1.1e0696p+4f;
case 0x65d890d3: case 0x65d890d3:
Show All 11 Lines