This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][NFC] add note to interface_symbols_linux.cpp about darwin
ClosedPublic

Authored by aralisza on Dec 16 2021, 1:07 PM.

Download Raw Diff

Details

Reviewers: None
Commits: rGfcfcc64ce921: [compiler-rt][NFC] add note to interface_symbols_linux.cpp about darwin

Summary

There were changes made to the linux version of this test that were not made for darwin
(see https://reviews.llvm.org/D115837) and this caused downstream failures.

Adding comment to this test to remind people to edit interface_symbols_darwin.cpp.
There is the reverse of this comment in the darwin file to remind us to edit the linux version already.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	60 ms	x64 debian > LLVM.Bindings/Go::go.test

Event Timeline

aralisza created this revision.Dec 16 2021, 1:07 PM

Herald added a subscriber: dberris. · View Herald TranscriptDec 16 2021, 1:07 PM

aralisza requested review of this revision.Dec 16 2021, 1:07 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2021, 1:07 PM

Herald added a subscriber: Restricted Project. · View Herald Transcript

accidentally a letter

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 1:08 PM

This revision was landed with ongoing or failed builds.

Closed by commit rGfcfcc64ce921: [compiler-rt][NFC] add note to interface_symbols_linux.cpp about darwin (authored by aralisza). · Explain Why

This revision was automatically updated to reflect the committed changes.

aralisza added a commit: rGfcfcc64ce921: [compiler-rt][NFC] add note to interface_symbols_linux.cpp about darwin.

Harbormaster completed remote builds in B139733: Diff 394973.Dec 16 2021, 1:28 PM

Revision Contents

Path

Size

compiler-rt/

test/

asan/

TestCases/

Linux/

interface_symbols_linux.cpp

2 lines

Diff 394973

compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.cpp

	// Check the presence of interface symbols in compiled file.			// Check the presence of interface symbols in compiled file.
				// If you're changing this file, please also change
				// ../Darwin/interface_symbols_darwin.cpp

	// RUN: %clangxx -x c++-header -o - -E %p/../../../../lib/asan/asan_interface.inc \			// RUN: %clangxx -x c++-header -o - -E %p/../../../../lib/asan/asan_interface.inc \
	// RUN: \| sed "s/INTERFACE_FUNCTION/\nINTERFACE_FUNCTION/g" > %t.asan_interface.inc			// RUN: \| sed "s/INTERFACE_FUNCTION/\nINTERFACE_FUNCTION/g" > %t.asan_interface.inc
	// RUN: %clangxx_asan -O2 %s -o %t.exe			// RUN: %clangxx_asan -O2 %s -o %t.exe
	// RUN: nm -D %t.exe \| grep " [TWw] " \			// RUN: nm -D %t.exe \| grep " [TWw] " \
	// RUN: \| grep -o "\(__asan_\\|__ubsan_\\|__sancov_\\|__sanitizer_\)[^ ]*" \			// RUN: \| grep -o "\(__asan_\\|__ubsan_\\|__sancov_\\|__sanitizer_\)[^ ]*" \
	// RUN: \| grep -v "__sanitizer_syscall" \			// RUN: \| grep -v "__sanitizer_syscall" \
	// RUN: \| grep -v "__sanitizer_weak_hook" \			// RUN: \| grep -v "__sanitizer_weak_hook" \
	Show All 25 Lines