This is an archive of the discontinued LLVM Phabricator instance.

[ASan] Renamed SHADOW_XYZ to ASAN_SHADOW_XYZ.
ClosedPublic

Authored by kstoimenov on Dec 7 2021, 3:18 PM.

Diff Detail

Event Timeline

kstoimenov requested review of this revision.Dec 7 2021, 3:18 PM
kstoimenov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2021, 3:18 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov edited the summary of this revision. (Show Details)Dec 7 2021, 3:22 PM
kstoimenov added a reviewer: vitalybuka.
vitalybuka accepted this revision.Dec 7 2021, 3:54 PM

ASAN_SHADOW_GRANULARITY causes a lot of noise, maybe keep that one as-is?
LGTM either way

compiler-rt/lib/asan/asan_rtl.cpp
364–367

No need to change Printfs, maybe something rely on them

This revision is now accepted and ready to land.Dec 7 2021, 3:54 PM
kstoimenov updated this revision to Diff 392581.Dec 7 2021, 3:59 PM

Addressed comments.

This revision was landed with ongoing or failed builds.Dec 7 2021, 4:23 PM
This revision was automatically updated to reflect the committed changes.