Change __lsan::kMaxAllowedMallocSize literal types to unsigned long long

[clemenswasser]

Summary

It is required for the Leak Sanitizer port to Windows.
The currently used unsigned long type is 64 bits wide on UNIX like systems but only 32 bits wide on Windows.
Because of that, the literal 8UL << 30 causes an integer overflow on Windows.
By changing the type of the literals to unsigned long long, we have consistent behavior and no overflows on all Platforms.

[vitalybuka]

I assume you have no committer access?

[clemenswasser]

In D115186#3174760, @vitalybuka wrote:

I assume you have no committer access?

I don't know. Is that important. Can you please explain what you mean by that? :)

[vitalybuka]

S

In D115186#3174798, @clemenswasser wrote:

In D115186#3174760, @vitalybuka wrote:

I assume you have no committer access?

I don't know. Is that important. Can you please explain what you mean by that? :)

If you asking then you unlikely have one. :) you can't push into git repo.
Someone else will need to commit patches for your, often reviewer.
I will do that.

[clemenswasser]

In D115186#3174939, @vitalybuka wrote:

S

In D115186#3174798, @clemenswasser wrote:

In D115186#3174760, @vitalybuka wrote:

I assume you have no committer access?

I don't know. Is that important. Can you please explain what you mean by that? :)

If you asking then you unlikely have one. :) you can't push into git repo.
Someone else will need to commit patches for your, often reviewer.
I will do that.

Do I have commit access, when I'm part of the LLVM GitHub Organization? I am for whatever reason a member :P

[vitalybuka]

In D115186#3174951, @clemenswasser wrote:

In D115186#3174939, @vitalybuka wrote:

S

In D115186#3174798, @clemenswasser wrote:

In D115186#3174760, @vitalybuka wrote:

I assume you have no committer access?

I don't know. Is that important. Can you please explain what you mean by that? :)

If you asking then you unlikely have one. :) you can't push into git repo.
Someone else will need to commit patches for your, often reviewer.
I will do that.

Do I have commit access, when I'm part of the LLVM GitHub Organization? I am for whatever reason a member :P

I don't know. You can try "arc land" or "git push" for this patch

[clemenswasser]

@vitalybuka No I don't have permissions to push. Could you please do it for me :)

compiler-rt/lib/lsan/lsan_allocator.cpp

 #include "sanitizer_common/sanitizer_stackdepot.h"
 #include "sanitizer_common/sanitizer_stacktrace.h"
 #include "lsan_common.h"
 
 extern "C" void *memset(void *ptr, int value, uptr num);
 
 namespace __lsan {
 #if defined(__i386__) || defined(__arm__)
-static const uptr kMaxAllowedMallocSize = 1UL << 30;
+static const uptr kMaxAllowedMallocSize = 1ULL << 30;
 #elif defined(__mips64) || defined(__aarch64__)
-static const uptr kMaxAllowedMallocSize = 4UL << 30;
+static const uptr kMaxAllowedMallocSize = 4ULL << 30;
 #else
-static const uptr kMaxAllowedMallocSize = 8UL << 30;
+static const uptr kMaxAllowedMallocSize = 8ULL << 30;
 #endif
 
 static Allocator allocator;
 
 static uptr max_malloc_size;
 
 void InitializeAllocator() {
   SetAllocatorMayReturnNull(common_flags()->allocator_may_return_null);