Page MenuHomePhabricator

[CMake] Workaround for PR24222: don't fail if we can't target COMPILER_RT_TEST_TARGET_TRIPLE unless it was explicitly set.
ClosedPublic

Authored by samsonov on Jul 24 2015, 2:31 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

samsonov updated this revision to Diff 30610.Jul 24 2015, 2:31 PM
samsonov retitled this revision from to [CMake] Workaround for PR24222: don't fail if we can't target COMPILER_RT_TEST_TARGET_TRIPLE unless it was explicitly set..
samsonov updated this object.
samsonov added a reviewer: hans.
samsonov added a subscriber: llvm-commits.
hans accepted this revision.Jul 24 2015, 2:45 PM
hans edited edge metadata.

lgtm, thanks.

It would be nice if we could fix the other half of PR24222 too though, where clang doesn't define i686.

This revision is now accepted and ready to land.Jul 24 2015, 2:45 PM
This revision was automatically updated to reflect the committed changes.