This is an archive of the discontinued LLVM Phabricator instance.

[HWASan] Try 'google' prefixed apex directories in symbolizer.
ClosedPublic

Authored by hctim on Dec 1 2021, 4:56 PM.

Details

Summary

Google-signed apexes appear on Android build servers' symbol files as
being under /apex/com.google.android.<foo>/. In reality, the apexes are
always installed as /apex/com.android.<foo>/ (note the lack of
'google'). In order for local symbolization under hwasan_symbolize to
work correctly, we also try the 'google' directory.

Diff Detail

Event Timeline

hctim requested review of this revision.Dec 1 2021, 4:56 PM
hctim created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2021, 4:56 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Dec 2 2021, 1:46 PM

LGTM

This revision is now accepted and ready to land.Dec 2 2021, 1:46 PM