This is an archive of the discontinued LLVM Phabricator instance.

Differential D114673

[libc++] Remove support for Clang 9 and older.
ClosedPublic

Authored by Mordante on Nov 28 2021, 4:18 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG730dccb98622: [libc++] Remove support for Clang 9 and older.
Summary

I encountered this while reviewing an unrelated patch. Will land after
the CI passes.

Diff Detail

Event Timeline

Mordante requested review of this revision.Nov 28 2021, 4:18 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2021, 4:18 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B136328: Diff 390194.Nov 28 2021, 5:31 AM
Mordante accepted this revision.Nov 28 2021, 6:16 AM
Mordante retitled this revision from [libc++] Remove Clang 10 support. to [libc++] Remove support for Clang 9 and older..
This revision is now accepted and ready to land.Nov 28 2021, 6:16 AM
Closed by commit rG730dccb98622: [libc++] Remove support for Clang 9 and older. (authored by Mordante). · Explain WhyNov 28 2021, 6:17 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG730dccb98622: [libc++] Remove support for Clang 9 and older..
ldionne added a subscriber: ldionne.Nov 29 2021, 6:17 AM

LGTM.

Revision Contents

PathSize
libcxx/
include/
4 lines

Diff 390199

libcxx/include/type_traits

Show First 20 Lines • Show All 1,410 Lines • ▼ Show 20 Lines
// type_identity // type_identity
#if _LIBCPP_STD_VER > 17 #if _LIBCPP_STD_VER > 17
template<class _Tp> struct type_identity { typedef _Tp type; }; template<class _Tp> struct type_identity { typedef _Tp type; };
template<class _Tp> using type_identity_t = typename type_identity<_Tp>::type; template<class _Tp> using type_identity_t = typename type_identity<_Tp>::type;
#endif #endif
// is_signed // is_signed
// Before Clang 10, __is_signed didn't work for floating-point types or enums. #if __has_keyword(__is_signed)
#if __has_keyword(__is_signed) && \
!(defined(_LIBCPP_CLANG_VER) && _LIBCPP_CLANG_VER < 1000)
template<class _Tp> template<class _Tp>
struct _LIBCPP_TEMPLATE_VIS is_signed : _BoolConstant<__is_signed(_Tp)> { }; struct _LIBCPP_TEMPLATE_VIS is_signed : _BoolConstant<__is_signed(_Tp)> { };
#if _LIBCPP_STD_VER > 14 #if _LIBCPP_STD_VER > 14
template <class _Tp> template <class _Tp>
inline constexpr bool is_signed_v = __is_signed(_Tp); inline constexpr bool is_signed_v = __is_signed(_Tp);
#endif #endif
▲ Show 20 Lines • Show All 2,748 Lines • Show Last 20 Lines