Have yaml2obj describe all options in --help

[probinson]

Summary

Looks like a couple of options were missing cl::cat(Cat) and so weren't in the help output.

[jhenderson]

LGTM. I don't think it is worth testing this, but for complete sanity, could you post the before and after help text in this thread, please?

[probinson]

Before:

OVERVIEW: Create an object file from a YAML description
USAGE: yaml2obj [options] <input file>

OPTIONS:

Generic Options:

  --help          - Display available options (--help-hidden for more)
  --help-list     - Display list of available options (--help-list-hidden for more)
  --version       - Display the version of this program

yaml2obj Options:

  --docnum=<uint> - Read specified document from input (default = 1)
  -o=<filename>   - Output filename

After:

OVERVIEW: Create an object file from a YAML description
USAGE: yaml2obj [options] <input file>

OPTIONS:

Generic Options:

  --help             - Display available options (--help-hidden for more)
  --help-list        - Display list of available options (--help-list-hidden for more)
  --version          - Display the version of this program

yaml2obj Options:

  -D=<string>        - Defined the specified macros to their specified definition. The syntax is <macro>=<definition>
  --docnum=<uint>    - Read specified document from input (default = 1)
  --max-size=<ulong> - Sets the maximum allowed output size (0 means no limit) [ELF only]
  -o=<filename>      - Output filename

llvm/tools/yaml2obj/yaml2obj.cpp

 cl::OptionCategory Cat("yaml2obj Options");
 
 cl::opt<std::string> Input(cl::Positional, cl::desc("<input file>"),
                            cl::init("-"), cl::cat(Cat));
 
 cl::list<std::string>
     D("D", cl::Prefix,
       cl::desc("Defined the specified macros to their specified "
-               "definition. The syntax is <macro>=<definition>"));
+               "definition. The syntax is <macro>=<definition>"),
+      cl::cat(Cat));
 
 cl::opt<unsigned>
     DocNum("docnum", cl::init(1),
            cl::desc("Read specified document from input (default = 1)"),
            cl::cat(Cat));
 
 static cl::opt<uint64_t> MaxSize(
     "max-size", cl::init(10 * 1024 * 1024),
     cl::desc(
-        "Sets the maximum allowed output size (0 means no limit) [ELF only]"));
+        "Sets the maximum allowed output size (0 means no limit) [ELF only]"),
+    cl::cat(Cat));
 
 cl::opt<std::string> OutputFilename("o", cl::desc("Output filename"),
                                     cl::value_desc("filename"), cl::init("-"),
                                     cl::Prefix, cl::cat(Cat));
 } // namespace
 
 static Optional<std::string> preprocess(StringRef Buf,
                                         yaml::ErrorHandler ErrHandler) {