Page MenuHomePhabricator

[libc++] Tidy up how %T and %t are created during configuration checks
ClosedPublic

Authored by ldionne on Nov 22 2021, 1:12 PM.

Details

Summary

Instead of having ad-hoc cleanup in various places, handle all creation
and removal of temporary files and directories inside _makeConfigTest.

As a fly-by, also remove testPrefix since we don't keep any source file
around anymore. Setting a prefix for the files is hence not useful anymore.

Diff Detail

Event Timeline

ldionne created this revision.Nov 22 2021, 1:12 PM
ldionne requested review of this revision.Nov 22 2021, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2021, 1:12 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Nov 23 2021, 6:51 AM
This revision is now accepted and ready to land.Nov 23 2021, 6:51 AM