This is an archive of the discontinued LLVM Phabricator instance.

Differential D114303

[hwasan] fix arguments to symbolizer.
ClosedPublic

Authored by fmayer on Nov 19 2021, 6:21 PM.

Details

Reviewers
hctim
Commits
rGed8b5b37abb1: [hwasan] fix arguments to symbolizer.
Summary

new versions do not accept -inlining of -functions (tested with 11 and
13).

Diff Detail

Event Timeline

fmayer requested review of this revision.Nov 19 2021, 6:21 PM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2021, 6:21 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
fmayer edited the summary of this revision. (Show Details)Nov 19 2021, 6:22 PM
fmayer added a reviewer: hctim.
Harbormaster completed remote builds in B135247: Diff 388673.Nov 19 2021, 6:41 PM
hctim accepted this revision.Nov 22 2021, 9:50 AM
This revision is now accepted and ready to land.Nov 22 2021, 9:50 AM
Closed by commit rGed8b5b37abb1: [hwasan] fix arguments to symbolizer. (authored by fmayer). · Explain WhyNov 22 2021, 9:59 AM
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rGed8b5b37abb1: [hwasan] fix arguments to symbolizer..

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
scripts/
2 lines

Diff 388959

compiler-rt/lib/hwasan/scripts/hwasan_symbolize

Show All 29 Lines def __init__(self, path, binary_prefixes, paths_to_cut):
self.__log = False self.__log = False
self.__warnings = set() self.__warnings = set()
def enable_logging(self, enable): def enable_logging(self, enable):
self.__log = enable self.__log = enable
def __open_pipe(self): def __open_pipe(self):
if not self.__pipe: if not self.__pipe:
self.__pipe = subprocess.Popen([self.__path, "-inlining", "-functions"], self.__pipe = subprocess.Popen([self.__path, "--inlining", "--functions"],
stdin=subprocess.PIPE, stdout=subprocess.PIPE) stdin=subprocess.PIPE, stdout=subprocess.PIPE)
class __EOF: class __EOF:
pass pass
def __write(self, s): def __write(self, s):
print >>self.__pipe.stdin, s print >>self.__pipe.stdin, s
if self.__log: if self.__log:
▲ Show 20 Lines • Show All 240 Lines • Show Last 20 Lines