Page MenuHomePhabricator

[X86][AVX512F] add arithmetic intrinsics
ClosedPublic

Authored by AsafBadouh on Jul 20 2015, 8:03 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

AsafBadouh updated this revision to Diff 30159.Jul 20 2015, 8:03 AM
AsafBadouh retitled this revision from to [X86][AVX512F] add arithmetic intrinsics.
AsafBadouh updated this object.
AsafBadouh added reviewers: mkuper, delena, igorb.
AsafBadouh set the repository for this revision to rL LLVM.
AsafBadouh added a subscriber: llvm-commits.
delena edited edge metadata.Jul 20 2015, 12:16 PM

I think that we are inconsistent with "setzero" and "undef" for PathThru values in this file. GCC uses "undef" and it is right.

lib/Headers/avx512fintrin.h
52 ↗(On Diff #30159)

This comment should be moved down, it is related to setzero.

889 ↗(On Diff #30159)

In all these cases we also should use "undefined". Right?

mkuper added inline comments.Jul 20 2015, 1:31 PM
lib/Headers/avx512fintrin.h
55 ↗(On Diff #30159)

What we need here is an undef value.
Are you sure this doesn't invoke undefined behavior?

My gut feeling is that the way to properly get an undef value would be to use a __builtin that evaluates to undef.

AsafBadouh marked an inline comment as done.Jul 21 2015, 6:58 AM
AsafBadouh added inline comments.
lib/Headers/avx512fintrin.h
889 ↗(On Diff #30159)

yes, it should use "undefined".

AsafBadouh updated this revision to Diff 30254.Jul 21 2015, 7:10 AM
AsafBadouh edited edge metadata.
AsafBadouh removed rL LLVM as the repository for this revision.
This revision was automatically updated to reflect the committed changes.