This is an archive of the discontinued LLVM Phabricator instance.

Differential D11285

freeaddrinfo(NULL) segfaults on Android.
ClosedPublic

Authored by chaoren on Jul 16 2015, 5:01 PM.

Details

Reviewers
tberghammer
Commits
rG2e3b97d4fbdf: freeaddrinfo(NULL) segfaults on Android.
rLLDB242560: freeaddrinfo(NULL) segfaults on Android.
rL242560: freeaddrinfo(NULL) segfaults on Android.

Diff Detail

Event Timeline

chaoren updated this revision to Diff 29966.Jul 16 2015, 5:01 PM
chaoren retitled this revision from to freeaddrinfo(NULL) segfaults on Android..
chaoren updated this object.
chaoren added a reviewer: tberghammer.
chaoren added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer. · View Herald TranscriptJul 16 2015, 5:01 PM
tberghammer accepted this revision.Jul 17 2015, 2:15 AM
tberghammer edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2015, 2:15 AM
chaoren mentioned this in rL242318: Default to linking lldb-server statically for Android..Jul 17 2015, 2:47 AM
Closed by commit rL242560: freeaddrinfo(NULL) segfaults on Android. (authored by chaoren). · Explain WhyJul 17 2015, 12:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
source/
Host/
common/
6 lines

Diff 29966

source/Host/common/SocketAddress.cpp

Show First 20 Lines • Show All 298 Lines • ▼ Show 20 LinesSocketAddress::getaddrinfo (const char *host,
bool result = false; bool result = false;
struct addrinfo *service_info_list = NULL; struct addrinfo *service_info_list = NULL;
int err = ::getaddrinfo (host, service, &hints, &service_info_list); int err = ::getaddrinfo (host, service, &hints, &service_info_list);
if (err == 0 && service_info_list) if (err == 0 && service_info_list)
{ {
*this = service_info_list; *this = service_info_list;
result = IsValid (); result = IsValid ();
} }
if (service_info_list)
:: freeaddrinfo (service_info_list); ::freeaddrinfo(service_info_list);
return result; return result;
} }
bool bool
SocketAddress::SetToLocalhost (sa_family_t family, uint16_t port) SocketAddress::SetToLocalhost (sa_family_t family, uint16_t port)
{ {
switch (family) switch (family)
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines