This is an archive of the discontinued LLVM Phabricator instance.

Differential D112210

[libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with explanation
ClosedPublic

Authored by mstorsjo on Oct 21 2021, 3:40 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGf5ee1acc62d5: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with…
Summary

This test doesn't fail in mingw mode (which uses the same Itanium
name mangling and ABI as other platforms).

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Oct 21 2021, 3:40 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2021, 3:40 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B129905: Diff 381200.Oct 21 2021, 4:33 AM
ldionne added inline comments.Oct 21 2021, 6:56 AM
libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
11–12

Isn't that a bug we need to fix?

mstorsjo added inline comments.Oct 21 2021, 7:16 AM
libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp
11–12

AFAIK this is not something that “we” as in libc++ can fix, it’s a property of the msvc C++ ABI.

ldionne accepted this revision.Oct 21 2021, 2:21 PM
This revision is now accepted and ready to land.Oct 21 2021, 2:21 PM
Closed by commit rGf5ee1acc62d5: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with… (authored by mstorsjo). · Explain WhyOct 21 2021, 3:02 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGf5ee1acc62d5: [libcxx] [test] Convert an XFAIL: LIBCXX-WINDOWS-FIXME into XFAIL: msvc with….

Revision Contents

PathSize
libcxx/
test/
libcxx/
language.support/
support.rtti/
type.info/
3 lines

Diff 381404

libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.merged.sh.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: no-rtti // UNSUPPORTED: no-rtti
// XFAIL: LIBCXX-WINDOWS-FIXME // In MSVC mode, the two anonymous types have identical type index in both object files.
// XFAIL: msvc
ldionneUnsubmitted
Not Done
ReplyInline Actions

Isn't that a bug we need to fix?

ldionne: Isn't that a bug we need to fix?
mstorsjoAuthorUnsubmitted
Done
ReplyInline Actions

AFAIK this is not something that “we” as in libc++ can fix, it’s a property of the msvc C++ ABI.

mstorsjo: AFAIK this is not something that “we” as in libc++ can fix, it’s a property of the msvc C++ ABI.
// RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu1.o -DTU1 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu1.o -DTU1 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1
// RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu2.o -DTU2 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.tu2.o -DTU2 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1
// RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.main.o -DMAIN -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1 // RUN: %{cxx} %s %{flags} %{compile_flags} -c -o %t.main.o -DMAIN -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=1
// RUN: %{cxx} %t.tu1.o %t.tu2.o %t.main.o %{flags} %{link_flags} -o %t.exe // RUN: %{cxx} %t.tu1.o %t.tu2.o %t.main.o %{flags} %{link_flags} -o %t.exe
// RUN: %{exec} %t.exe // RUN: %{exec} %t.exe
#include <cassert> #include <cassert>
Show All 28 Lines