[clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

[thakis]

Summary

CFGBuilder::addStmt() implicitly passes AddStmtChoice::AlwaysAdd
to Visit() already, so this should have no behavior change.

[hans]

I guess I don't have enough context here. Why is AttributedStmtClass special here? Is it because it's a statement and the others are expressions, and so wouldn't go through CFGBlock::addStmt()?

[thakis]

Yes, that's my understanding. (I'm not super familiar with this code either.)

The line was added in the change that added -Wimplicit-fallthrough (84837d5b5aa0d), and all the -Wimplicit-fallthrough tests still pass with this. Chances are it was unnecessary back then too.

(addStmt is from ea9fcffe035d, way older.)

[hans]

Sounds good to me :)

clang/lib/Sema/AnalysisBasedWarnings.cpp

void clang::sema::AnalysisBasedWarnings::IssueWarnings(
   else {
     AC.getCFGBuildOptions()
       .setAlwaysAdd(Stmt::BinaryOperatorClass)
       .setAlwaysAdd(Stmt::CompoundAssignOperatorClass)
       .setAlwaysAdd(Stmt::BlockExprClass)
       .setAlwaysAdd(Stmt::CStyleCastExprClass)
       .setAlwaysAdd(Stmt::DeclRefExprClass)
       .setAlwaysAdd(Stmt::ImplicitCastExprClass)
-      .setAlwaysAdd(Stmt::UnaryOperatorClass)
-      .setAlwaysAdd(Stmt::AttributedStmtClass);
+      .setAlwaysAdd(Stmt::UnaryOperatorClass);
   }
 
   // Install the logical handler.
   llvm::Optional<LogicalErrorHandler> LEH;
   if (LogicalErrorHandler::hasActiveDiagnostics(Diags, D->getBeginLoc())) {
     LEH.emplace(S);
     AC.getCFGBuildOptions().Observer = &*LEH;
   }