This is an archive of the discontinued LLVM Phabricator instance.

Differential D110648

[clang] skip serializing external methods in pcm files
DraftPublic

Authored by rmaz on Sep 28 2021, 12:13 PM.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None

Diff Detail

Revision Contents

PathSize
clang/
lib/
Serialization/
2 lines
12 lines

Diff 375663

clang/lib/Serialization/ASTReader.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,124 Lines • ▼ Show 20 Lines bool operator()(ModuleFile &M) {
Reader.DeserializationListener->SelectorRead(Data.ID, Sel); Reader.DeserializationListener->SelectorRead(Data.ID, Sel);
InstanceMethods.append(Data.Instance.begin(), Data.Instance.end()); InstanceMethods.append(Data.Instance.begin(), Data.Instance.end());
FactoryMethods.append(Data.Factory.begin(), Data.Factory.end()); FactoryMethods.append(Data.Factory.begin(), Data.Factory.end());
InstanceBits = Data.InstanceBits; InstanceBits = Data.InstanceBits;
FactoryBits = Data.FactoryBits; FactoryBits = Data.FactoryBits;
InstanceHasMoreThanOneDecl = Data.InstanceHasMoreThanOneDecl; InstanceHasMoreThanOneDecl = Data.InstanceHasMoreThanOneDecl;
FactoryHasMoreThanOneDecl = Data.FactoryHasMoreThanOneDecl; FactoryHasMoreThanOneDecl = Data.FactoryHasMoreThanOneDecl;
return true; return false;
} }
/// Retrieve the instance methods found by this visitor. /// Retrieve the instance methods found by this visitor.
ArrayRef<ObjCMethodDecl *> getInstanceMethods() const { ArrayRef<ObjCMethodDecl *> getInstanceMethods() const {
return InstanceMethods; return InstanceMethods;
} }
/// Retrieve the instance methods found by this visitor. /// Retrieve the instance methods found by this visitor.
▲ Show 20 Lines • Show All 4,865 Lines • Show Last 20 Lines

clang/lib/Serialization/ASTWriter.cpp

Show First 20 Lines • Show All 3,006 Lines • ▼ Show 20 Lines std::pair<unsigned, unsigned>
using namespace llvm::support; using namespace llvm::support;
endian::Writer LE(Out, little); endian::Writer LE(Out, little);
unsigned KeyLen = 2 + (Sel.getNumArgs()? Sel.getNumArgs() * 4 : 4); unsigned KeyLen = 2 + (Sel.getNumArgs()? Sel.getNumArgs() * 4 : 4);
LE.write<uint16_t>(KeyLen); LE.write<uint16_t>(KeyLen);
unsigned DataLen = 4 + 2 + 2; // 2 bytes for each of the method counts unsigned DataLen = 4 + 2 + 2; // 2 bytes for each of the method counts
for (const ObjCMethodList *Method = &Methods.Instance; Method; for (const ObjCMethodList *Method = &Methods.Instance; Method;
Method = Method->getNext()) Method = Method->getNext())
if (Method->getMethod()) if (Method->getMethod() && !Method->getMethod()->isFromASTFile())
DataLen += 4; DataLen += 4;
for (const ObjCMethodList *Method = &Methods.Factory; Method; for (const ObjCMethodList *Method = &Methods.Factory; Method;
Method = Method->getNext()) Method = Method->getNext())
if (Method->getMethod()) if (Method->getMethod() && !Method->getMethod()->isFromASTFile())
DataLen += 4; DataLen += 4;
LE.write<uint16_t>(DataLen); LE.write<uint16_t>(DataLen);
return std::make_pair(KeyLen, DataLen); return std::make_pair(KeyLen, DataLen);
} }
void EmitKey(raw_ostream& Out, Selector Sel, unsigned) { void EmitKey(raw_ostream& Out, Selector Sel, unsigned) {
using namespace llvm::support; using namespace llvm::support;
Show All 15 Lines void EmitData(raw_ostream& Out, key_type_ref,
using namespace llvm::support; using namespace llvm::support;
endian::Writer LE(Out, little); endian::Writer LE(Out, little);
uint64_t Start = Out.tell(); (void)Start; uint64_t Start = Out.tell(); (void)Start;
LE.write<uint32_t>(Methods.ID); LE.write<uint32_t>(Methods.ID);
unsigned NumInstanceMethods = 0; unsigned NumInstanceMethods = 0;
for (const ObjCMethodList *Method = &Methods.Instance; Method; for (const ObjCMethodList *Method = &Methods.Instance; Method;
Method = Method->getNext()) Method = Method->getNext())
if (Method->getMethod()) if (Method->getMethod() && !Method->getMethod()->isFromASTFile())
++NumInstanceMethods; ++NumInstanceMethods;
unsigned NumFactoryMethods = 0; unsigned NumFactoryMethods = 0;
for (const ObjCMethodList *Method = &Methods.Factory; Method; for (const ObjCMethodList *Method = &Methods.Factory; Method;
Method = Method->getNext()) Method = Method->getNext())
if (Method->getMethod()) if (Method->getMethod() && !Method->getMethod()->isFromASTFile())
++NumFactoryMethods; ++NumFactoryMethods;
unsigned InstanceBits = Methods.Instance.getBits(); unsigned InstanceBits = Methods.Instance.getBits();
assert(InstanceBits < 4); assert(InstanceBits < 4);
unsigned InstanceHasMoreThanOneDeclBit = unsigned InstanceHasMoreThanOneDeclBit =
Methods.Instance.hasMoreThanOneDecl(); Methods.Instance.hasMoreThanOneDecl();
unsigned FullInstanceBits = (NumInstanceMethods << 3) | unsigned FullInstanceBits = (NumInstanceMethods << 3) |
(InstanceHasMoreThanOneDeclBit << 2) | (InstanceHasMoreThanOneDeclBit << 2) |
InstanceBits; InstanceBits;
unsigned FactoryBits = Methods.Factory.getBits(); unsigned FactoryBits = Methods.Factory.getBits();
assert(FactoryBits < 4); assert(FactoryBits < 4);
unsigned FactoryHasMoreThanOneDeclBit = unsigned FactoryHasMoreThanOneDeclBit =
Methods.Factory.hasMoreThanOneDecl(); Methods.Factory.hasMoreThanOneDecl();
unsigned FullFactoryBits = (NumFactoryMethods << 3) | unsigned FullFactoryBits = (NumFactoryMethods << 3) |
(FactoryHasMoreThanOneDeclBit << 2) | (FactoryHasMoreThanOneDeclBit << 2) |
FactoryBits; FactoryBits;
LE.write<uint16_t>(FullInstanceBits); LE.write<uint16_t>(FullInstanceBits);
LE.write<uint16_t>(FullFactoryBits); LE.write<uint16_t>(FullFactoryBits);
for (const ObjCMethodList *Method = &Methods.Instance; Method; for (const ObjCMethodList *Method = &Methods.Instance; Method;
Method = Method->getNext()) Method = Method->getNext())
if (Method->getMethod()) if (Method->getMethod() && !Method->getMethod()->isFromASTFile())
LE.write<uint32_t>(Writer.getDeclID(Method->getMethod())); LE.write<uint32_t>(Writer.getDeclID(Method->getMethod()));
for (const ObjCMethodList *Method = &Methods.Factory; Method; for (const ObjCMethodList *Method = &Methods.Factory; Method;
Method = Method->getNext()) Method = Method->getNext())
if (Method->getMethod()) if (Method->getMethod() && !Method->getMethod()->isFromASTFile())
LE.write<uint32_t>(Writer.getDeclID(Method->getMethod())); LE.write<uint32_t>(Writer.getDeclID(Method->getMethod()));
assert(Out.tell() - Start == DataLen && "Data length is wrong"); assert(Out.tell() - Start == DataLen && "Data length is wrong");
} }
}; };
} // namespace } // namespace
▲ Show 20 Lines • Show All 3,759 Lines • Show Last 20 Lines