This is an archive of the discontinued LLVM Phabricator instance.

[lldb-mi] Use 'override' on overridden virtual methods.
ClosedPublic

Authored by brucem on Jul 6 2015, 7:27 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 29086.Jul 6 2015, 7:27 AM
brucem retitled this revision from to [lldb-mi] Use 'override' on overridden virtual methods..
brucem updated this object.
brucem added reviewers: abidh, ki.stfu.
brucem added a subscriber: lldb-commits.
abidh accepted this revision.Jul 6 2015, 8:06 AM
abidh edited edge metadata.

Apart from one small change, looks good.

tools/lldb-mi/MICmdArgValBase.h
46 ↗(On Diff #29086)

You missed this line.

This revision is now accepted and ready to land.Jul 6 2015, 8:06 AM
ki.stfu accepted this revision.Jul 6 2015, 8:26 AM
ki.stfu edited edge metadata.
This revision was automatically updated to reflect the committed changes.