This is an archive of the discontinued LLVM Phabricator instance.

Differential D10945

Verifier: Forbid comdats on linker declarations.
ClosedPublic

Authored by pcc on Jul 4 2015, 3:32 PM.

Details

Reviewers
• rafael
Commits
rG46eb0f539c0e: Verifier: Forbid comdats on linker declarations.
rL241414: Verifier: Forbid comdats on linker declarations.
Summary

Depends on http://reviews.llvm.org/D10941

Diff Detail

Event Timeline

pcc updated this revision to Diff 29050.Jul 4 2015, 3:32 PM
pcc retitled this revision from to Verifier: Forbid comdats on linker declarations..
pcc updated this object.
pcc added a reviewer: • rafael.
pcc added a subscriber: llvm-commits.
• rafael accepted this revision.Jul 5 2015, 4:14 AM
• rafael edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 5 2015, 4:14 AM
Closed by commit rL241414: Verifier: Forbid comdats on linker declarations. (authored by pcc). · Explain WhyJul 5 2015, 1:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
IR/
3 lines
test/
Verifier/
5 lines
5 lines

Diff 29050

lib/IR/Verifier.cpp

Show First 20 Lines • Show All 432 Lines • ▼ Show 20 Linesvoid Verifier::visitGlobalValue(const GlobalValue &GV) {
Assert(!GV.hasAppendingLinkage() || isa<GlobalVariable>(GV), Assert(!GV.hasAppendingLinkage() || isa<GlobalVariable>(GV),
"Only global variables can have appending linkage!", &GV); "Only global variables can have appending linkage!", &GV);
if (GV.hasAppendingLinkage()) { if (GV.hasAppendingLinkage()) {
const GlobalVariable *GVar = dyn_cast<GlobalVariable>(&GV); const GlobalVariable *GVar = dyn_cast<GlobalVariable>(&GV);
Assert(GVar && GVar->getValueType()->isArrayTy(), Assert(GVar && GVar->getValueType()->isArrayTy(),
"Only global arrays can have appending linkage!", GVar); "Only global arrays can have appending linkage!", GVar);
} }
if (GV.isDeclarationForLinker())
Assert(!GV.hasComdat(), "Declaration may not be in a Comdat!", &GV);
} }
void Verifier::visitGlobalVariable(const GlobalVariable &GV) { void Verifier::visitGlobalVariable(const GlobalVariable &GV) {
if (GV.hasInitializer()) { if (GV.hasInitializer()) {
Assert(GV.getInitializer()->getType() == GV.getType()->getElementType(), Assert(GV.getInitializer()->getType() == GV.getType()->getElementType(),
"Global variable initializer type does not match global " "Global variable initializer type does not match global "
"variable type!", "variable type!",
&GV); &GV);
▲ Show 20 Lines • Show All 3,267 Lines • Show Last 20 Lines

test/Verifier/comdat-decl1.ll

  • This file was added.
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
$v = comdat any
@v = available_externally global i32 0, comdat
; CHECK: Declaration may not be in a Comdat!

test/Verifier/comdat-decl2.ll

  • This file was added.
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
$v = comdat any
@v = external global i32, comdat
; CHECK: Declaration may not be in a Comdat!