Page MenuHomePhabricator

[clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment
ClosedPublic

Authored by wingo on Aug 20 2021, 1:02 AM.

Details

Summary

This function was defaulting to use the ABI alignment for the LLVM
type. Here we change to use the preferred alignment. This will allow
unification with GetTempAlloca, which if alignment isn't specified, uses
the preferred alignment.

Diff Detail

Event Timeline

wingo requested review of this revision.Aug 20 2021, 1:02 AM
wingo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2021, 1:02 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
wingo added a comment.Aug 20 2021, 1:10 AM

I tested by building with all targets enabled and there was no change in test results, running clang, llvm, and lld tests.

rjmccall accepted this revision.Aug 20 2021, 10:53 AM

Sure, I guess there's no harm in this.

This revision is now accepted and ready to land.Aug 20 2021, 10:53 AM
This revision was landed with ongoing or failed builds.Aug 23 2021, 6:09 AM
This revision was automatically updated to reflect the committed changes.