This is an archive of the discontinued LLVM Phabricator instance.

Differential D10778

timegm in LibcGlue needs to be extern, not static.
ClosedPublic

Authored by chaoren on Jun 26 2015, 2:16 PM.

Details

Reviewers
vharron
Commits
rGccc06b36c1ce: timegm in LibcGlue needs to be extern, not static.
rLLDB240894: timegm in LibcGlue needs to be extern, not static.
rL240894: timegm in LibcGlue needs to be extern, not static.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 28598.Jun 26 2015, 2:16 PM
chaoren retitled this revision from to timegm in LibcGlue needs to be extern, not static..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added a reviewer: vharron.
chaoren added a subscriber: Unknown Object (MLST).
vharron accepted this revision.Jun 26 2015, 8:33 PM
vharron edited edge metadata.
This revision is now accepted and ready to land.Jun 26 2015, 8:33 PM
Closed by commit rL240894: timegm in LibcGlue needs to be extern, not static. (authored by chaoren). · Explain WhyJun 27 2015, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
include/
lldb/
Host/
2 lines

Diff 28634

lldb/trunk/include/lldb/Host/Time.h

Show All 12 Lines
#define liblldb_Host_Time_h_ #define liblldb_Host_Time_h_
#ifdef __ANDROID_NDK__ #ifdef __ANDROID_NDK__
#include <android/api-level.h> #include <android/api-level.h>
#endif #endif
#if defined(__ANDROID_API__) && __ANDROID_API__ < 21 #if defined(__ANDROID_API__) && __ANDROID_API__ < 21
#include <time64.h> #include <time64.h>
static time_t timegm(struct tm* t); extern time_t timegm(struct tm* t);
#else #else
#include <time.h> #include <time.h>
#endif #endif
#endif // liblldb_Host_Time_h_ #endif // liblldb_Host_Time_h_