This is an archive of the discontinued LLVM Phabricator instance.

Differential D107619

[InstrProfiling] Fix warnings when building for Windows
ClosedPublic

Authored by mstorsjo on Aug 5 2021, 11:21 PM.

Details

Reviewers
MaskRay
Commits
rG743f78ef7fca: [InstrProfiling] Fix warnings when building for Windows
Summary

The Headers.CountersDelta field is an uint64_t, not a pointer,
so just cast to uint32_t to truncate it.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Aug 5 2021, 11:21 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2021, 11:21 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B118318: Diff 364700.Aug 5 2021, 11:53 PM
MaskRay accepted this revision.Aug 6 2021, 7:56 PM

Looks great!

This revision is now accepted and ready to land.Aug 6 2021, 7:56 PM
Closed by commit rG743f78ef7fca: [InstrProfiling] Fix warnings when building for Windows (authored by mstorsjo). · Explain WhyAug 9 2021, 1:39 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG743f78ef7fca: [InstrProfiling] Fix warnings when building for Windows.

Revision Contents

PathSize
compiler-rt/
lib/
profile/
2 lines

Diff 365122

compiler-rt/lib/profile/InstrProfilingWriter.c

Show First 20 Lines • Show All 280 Lines • ▼ Show 20 Lines
/* Initialize header structure. */ /* Initialize header structure. */
#define INSTR_PROF_RAW_HEADER(Type, Name, Init) Header.Name = Init; #define INSTR_PROF_RAW_HEADER(Type, Name, Init) Header.Name = Init;
#include "profile/InstrProfData.inc" #include "profile/InstrProfData.inc"
/* On WIN64, label differences are truncated 32-bit values. Truncate /* On WIN64, label differences are truncated 32-bit values. Truncate
* CountersDelta to match. */ * CountersDelta to match. */
#ifdef _WIN64 #ifdef _WIN64
Header.CountersDelta = (void *)(uint32_t)Header.CountersDelta; Header.CountersDelta = (uint32_t)Header.CountersDelta;
#endif #endif
/* Write the profile header. */ /* Write the profile header. */
ProfDataIOVec IOVec[] = {{&Header, sizeof(__llvm_profile_header), 1, 0}}; ProfDataIOVec IOVec[] = {{&Header, sizeof(__llvm_profile_header), 1, 0}};
if (Writer->Write(Writer, IOVec, sizeof(IOVec) / sizeof(*IOVec))) if (Writer->Write(Writer, IOVec, sizeof(IOVec) / sizeof(*IOVec)))
return -1; return -1;
/* Write the binary id lengths and data. */ /* Write the binary id lengths and data. */
Show All 20 Lines