This is an archive of the discontinued LLVM Phabricator instance.

Differential D107510

[gwpAsan] revert minor change
ClosedPublic

Authored by michaelrj on Aug 4 2021, 4:09 PM.

Details

Reviewers
None
Commits
rGf135a91c72c5: [gwpAsan] revert minor change
Summary

This change reverts a small cmake change that was causing buildbot
failures.

Diff Detail

Event Timeline

michaelrj created this revision.Aug 4 2021, 4:09 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 4 2021, 4:09 PM
michaelrj requested review of this revision.Aug 4 2021, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 4:09 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2021, 4:24 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGf135a91c72c5: [gwpAsan] revert minor change (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGf135a91c72c5: [gwpAsan] revert minor change.
Harbormaster completed remote builds in B118031: Diff 364281.Aug 4 2021, 4:37 PM

Revision Contents

PathSize
compiler-rt/
lib/
gwp_asan/
4 lines

Diff 364284

compiler-rt/lib/gwp_asan/CMakeLists.txt

Show All 27 Linesset(GWP_ASAN_HEADERS
platform_specific/mutex_posix.h platform_specific/mutex_posix.h
stack_trace_compressor.h stack_trace_compressor.h
utilities.h utilities.h
) )
# Ensure that GWP-ASan meets the delegated requirements of some supporting # Ensure that GWP-ASan meets the delegated requirements of some supporting
# allocators. Some supporting allocators (e.g. scudo standalone) cannot use any # allocators. Some supporting allocators (e.g. scudo standalone) cannot use any
# parts of the C++ standard library. # parts of the C++ standard library.
set(GWP_ASAN_CFLAGS -fno-rtti -fno-exceptions set(GWP_ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS} -fno-rtti -fno-exceptions
-nostdinc++ -pthread -fno-omit-frame-pointer) -nostdinc++ -pthread -fno-omit-frame-pointer)
append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC GWP_ASAN_CFLAGS) append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC GWP_ASAN_CFLAGS)
append_list_if(COMPILER_RT_HAS_SANITIZER_COMMON, ${SANITIZER_COMMON_CFLAGS} GWP_ASAN_CFLAGS) # append_list_if(COMPILER_RT_HAS_SANITIZER_COMMON ${SANITIZER_COMMON_CFLAGS} GWP_ASAN_CFLAGS)
# Remove -stdlib= which is unused when passing -nostdinc++. # Remove -stdlib= which is unused when passing -nostdinc++.
string(REGEX REPLACE "-stdlib=[a-zA-Z+]*" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) string(REGEX REPLACE "-stdlib=[a-zA-Z+]*" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
# Options parsing support is optional. This is an optional library that can be # Options parsing support is optional. This is an optional library that can be
# used by an allocator to automatically parse GwpAsan options from the # used by an allocator to automatically parse GwpAsan options from the
# environment variable GWP_ASAN_FLAGS, but the allocator can choose to implement # environment variable GWP_ASAN_FLAGS, but the allocator can choose to implement
# its own options parsing and populate the Options struct itself. # its own options parsing and populate the Options struct itself.
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines