This is an archive of the discontinued LLVM Phabricator instance.

Differential D106974

libcang: Add missing function to libclang.map
ClosedPublic

Authored by tstellar on Jul 28 2021, 10:07 AM.

Details

Reviewers
jrtc27
Commits
rGa4edb2b1ba0b: libcang: Add missing function to libclang.map
Summary

This function is marked with CINDEX_LINKAGE, but was never added to the
export list / linker script.

Diff Detail

Event Timeline

tstellar requested review of this revision.Jul 28 2021, 10:07 AM
tstellar created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 10:07 AM
tstellar mentioned this in D105527: libclang.so: Make SONAME independent from LLVM version.Jul 28 2021, 10:08 AM
tstellar updated this revision to Diff 362439.Jul 28 2021, 10:10 AM

Add missing ;

jrtc27 accepted this revision.Jul 28 2021, 10:35 AM

Thanks; I can confirm the test passes if and only if I apply this patch

This revision is now accepted and ready to land.Jul 28 2021, 10:35 AM
Harbormaster completed remote builds in B116734: Diff 362439.Jul 28 2021, 12:21 PM
This revision was landed with ongoing or failed builds.Jul 28 2021, 9:07 PM
Closed by commit rGa4edb2b1ba0b: libcang: Add missing function to libclang.map (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rGa4edb2b1ba0b: libcang: Add missing function to libclang.map.

Revision Contents

PathSize
clang/
tools/
libclang/
1 line

Diff 362621

clang/tools/libclang/libclang.map

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines global:
clang_CompilationDatabase_getAllCompileCommands; clang_CompilationDatabase_getAllCompileCommands;
clang_CompilationDatabase_getCompileCommands; clang_CompilationDatabase_getCompileCommands;
clang_CompileCommand_getArg; clang_CompileCommand_getArg;
clang_CompileCommand_getDirectory; clang_CompileCommand_getDirectory;
clang_CompileCommand_getFilename; clang_CompileCommand_getFilename;
clang_CompileCommand_getMappedSourceContent; clang_CompileCommand_getMappedSourceContent;
clang_CompileCommand_getMappedSourcePath; clang_CompileCommand_getMappedSourcePath;
clang_CompileCommand_getNumArgs; clang_CompileCommand_getNumArgs;
clang_CompileCommand_getNumMappedSources;
clang_CompileCommands_dispose; clang_CompileCommands_dispose;
clang_CompileCommands_getCommand; clang_CompileCommands_getCommand;
clang_CompileCommands_getSize; clang_CompileCommands_getSize;
clang_Cursor_Evaluate; clang_Cursor_Evaluate;
clang_Cursor_getArgument; clang_Cursor_getArgument;
clang_Cursor_getBriefCommentText; clang_Cursor_getBriefCommentText;
clang_Cursor_getCXXManglings; clang_Cursor_getCXXManglings;
clang_Cursor_getCommentRange; clang_Cursor_getCommentRange;
▲ Show 20 Lines • Show All 356 Lines • Show Last 20 Lines