This is an archive of the discontinued LLVM Phabricator instance.

Differential D106935

[libc++][nfc] Improve error diagnostics.
ClosedPublic

Authored by Mordante on Jul 27 2021, 11:14 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG4e6568857122: [libc++][nfc] Improve error diagnostics.
Summary

The error message for disabled filesystem and locale support is now done
in the same fashion as ranges and format in D106763.

Diff Detail

Event Timeline

Mordante requested review of this revision.Jul 27 2021, 11:14 PM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2021, 11:14 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B116622: Diff 362288.Jul 28 2021, 1:12 AM
ldionne accepted this revision.Jul 28 2021, 7:01 AM
This revision is now accepted and ready to land.Jul 28 2021, 7:01 AM
Closed by commit rG4e6568857122: [libc++][nfc] Improve error diagnostics. (authored by Mordante). · Explain WhyJul 28 2021, 8:57 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG4e6568857122: [libc++][nfc] Improve error diagnostics..

Revision Contents

PathSize
libcxx/
include/
2 lines
3 lines

Diff 362417

libcxx/include/filesystem

Show First 20 Lines • Show All 247 Lines • ▼ Show 20 Lines
#include <version> #include <version>
#if !defined(_LIBCPP_HAS_NO_LOCALIZATION) #if !defined(_LIBCPP_HAS_NO_LOCALIZATION)
# include <locale> # include <locale>
# include <iomanip> // for quoted # include <iomanip> // for quoted
#endif #endif
#if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY) #if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY)
# error "The Filesystem library is not supported by this configuration of libc++" # error "The Filesystem library is not supported since libc++ has been configured with LIBCXX_ENABLE_FILESYSTEM disabled"
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
#pragma GCC system_header #pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 2,748 Lines • Show Last 20 Lines

libcxx/include/locale.h

Show All 30 LinesFunctions:
setlocale setlocale
localeconv localeconv
*/ */
#include <__config> #include <__config>
#if defined(_LIBCPP_HAS_NO_LOCALIZATION) #if defined(_LIBCPP_HAS_NO_LOCALIZATION)
# error "Localization is not supported by this configuration of libc++" #error \
"The Localization library is not supported since libc++ has been configured with LIBCXX_ENABLE_LOCALIZATION disabled"
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#include_next <locale.h> #include_next <locale.h>
#endif // _LIBCPP_LOCALE_H #endif // _LIBCPP_LOCALE_H