This is an archive of the discontinued LLVM Phabricator instance.

[dfsan][NFC] Describe how origin trace tracking works
ClosedPublic

Authored by stephan.yichao.zhao on Jul 27 2021, 11:58 AM.

Diff Detail

Event Timeline

stephan.yichao.zhao requested review of this revision.Jul 27 2021, 11:58 AM
stephan.yichao.zhao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2021, 11:58 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gbalats added inline comments.Jul 27 2021, 12:04 PM
clang/docs/DataFlowSanitizerDesign.rst
142

What is a chain? It's not yet explained at this point.

152

Do you mean that the chain is extended?

155

same here

157

I'm not sure I understand the definition of a chain. What are the links? When you say, "create a new chain" you mean adding a new link to an existing chain? I think you might be using this expression to reflect the implementation (e.g., chain has a pointer to its tail) but it doesn't help when explaining.

explained what a trace and a chain are.

stephan.yichao.zhao marked 4 inline comments as done.Jul 27 2021, 1:17 PM
gbalats accepted this revision.Jul 27 2021, 2:00 PM
This revision is now accepted and ready to land.Jul 27 2021, 2:00 PM
This revision was landed with ongoing or failed builds.Jul 27 2021, 2:11 PM
This revision was automatically updated to reflect the committed changes.