This is an archive of the discontinued LLVM Phabricator instance.

Differential D106027

Allow setting CLANG_LINKS_TO_CREATE to an empty list
Needs ReviewPublic

Authored by veprbl on Jul 14 2021, 5:29 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

A user might want to redefine CLANG_LINKS_TO_CREATE to an empty list "", but such a value would be considered as a FALSE by cmake.

Diff Detail

Event Timeline

veprbl created this revision.Jul 14 2021, 5:29 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 14 2021, 5:29 PM
veprbl requested review of this revision.Jul 14 2021, 5:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2021, 5:29 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B114123: Diff 358789.Jul 14 2021, 6:07 PM

Revision Contents

PathSize
clang/
tools/
driver/
2 lines

Diff 358789

clang/tools/driver/CMakeLists.txt

Context not available.
add_dependencies(clang clang-resource-headers) add_dependencies(clang clang-resource-headers)
if(NOT CLANG_LINKS_TO_CREATE) if(NOT DEFINED CLANG_LINKS_TO_CREATE)
set(CLANG_LINKS_TO_CREATE clang++ clang-cl clang-cpp) set(CLANG_LINKS_TO_CREATE clang++ clang-cl clang-cpp)
endif() endif()
Context not available.