[lldb] Always call DestroyImpl from Process::Finalize

[JDevlieghere]

Summary

Always destroy the process, regardless of its private state. This will call the virtual function DoDestroy under the hood, giving our derived class a chance to do the necessary tear down, including what to do when the private state is eStateExited.

[jingham]

This seems better to me. It's a little odd that the Process was short-cutting DoDestroy for these states. How can it know that one of the plugins might not need to handle that case? As an object lesson, that's true of eStateInvalid, which is the state you return with in the ProcessGDBRemote case when interrupting the stub fails, and that definitely needs cleanup.

Looks like the Windows plugin handles these cases already anyway, so this should be good.

lldb/source/Target/Process.cpp

static ProcessPropertiesSP *g_settings_sp_ptr =
       new ProcessPropertiesSP(new ProcessProperties(nullptr));
   return *g_settings_sp_ptr;
 }
 
 void Process::Finalize() {
   if (m_finalizing.exchange(true))
     return;
 
-  // Destroy this process if needed
-  switch (GetPrivateState()) {
-  case eStateConnected:
-  case eStateAttaching:
-  case eStateLaunching:
-  case eStateStopped:
-  case eStateRunning:
-  case eStateStepping:
-  case eStateCrashed:
-  case eStateSuspended:
-    DestroyImpl(false);
-    break;
-
-  case eStateInvalid:
-  case eStateUnloaded:
-  case eStateDetached:
-  case eStateExited:
-    break;
-  }
+  // Destroy the process. This will call the virtual function DoDestroy under
+  // the hood, giving our derived class a chance to do the ncessary tear down.
 
   // Clear our broadcaster before we proceed with destroying
   Broadcaster::Clear();
 
   // Do any cleanup needed prior to being destructed... Subclasses that
   // override this method should call this superclass method as well.
 
   // We need to destroy the loader before the derived Process class gets