This is an archive of the discontinued LLVM Phabricator instance.

Differential D105833

[Bazel] ignore build files under libcxx's copy of google-benchmark
ClosedPublic

Authored by GMNGeoffrey on Jul 12 2021, 12:15 PM.

Details

Reviewers
chandlerc
Commits
rG279c3a5be3b4: [Bazel] ignore build files under libcxx's copy of google-benchmark
Summary

https://github.com/llvm/llvm-project/commit/5208ec5c66dc updated the
of google-benchmark under libcxx adding a BUILD.bazel file. This upsets
Bazel in our overlay configuration because it tries to interpret this
file.

Currently this is breaking the CI:
https://buildkite.com/llvm-project/upstream-bazel-rbe/builds/1828

Tested (same command the CI uses)
bazel query //... + @llvm-project//... | xargs bazel test --config=generic-clang --config=rbe --test_output=errors --test_tag_filters=-nobuildkite --build_tag_filters=-nobuildkite

Diff Detail

Event Timeline

GMNGeoffrey requested review of this revision.Jul 12 2021, 12:15 PM
GMNGeoffrey created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2021, 12:16 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
GMNGeoffrey edited the summary of this revision. (Show Details)Jul 12 2021, 12:17 PM
GMNGeoffrey added a reviewer: chandlerc.
GMNGeoffrey added a comment.Jul 12 2021, 12:44 PM

This is needed to unbreak the build, so landing and asking for post-commit review

This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2021, 12:46 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG279c3a5be3b4: [Bazel] ignore build files under libcxx's copy of google-benchmark (authored by GMNGeoffrey). · Explain Why
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rG279c3a5be3b4: [Bazel] ignore build files under libcxx's copy of google-benchmark.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
2 lines

Diff 358039

utils/bazel/llvm-project-overlay/.bazelignore

# Ignore the utils/bazel directory when this is overlayed onto the repo root. # Ignore the utils/bazel directory when this is overlayed onto the repo root.
utils/bazel utils/bazel
# This directory has a Bazel config
libcxx/utils/google-benchmark