Page MenuHomePhabricator

[LLD] COFF: Fix unsafe memory access
ClosedPublic

Authored by ruiu on Jun 18 2015, 1:06 PM.

Details

Reviewers
pcc
Summary

BitcodeFile::M is freed before the writer writes a result because of presence
of BitcodeFile::releaseModule(). So we cannot keep pointers to bitcode files
in symbols.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 27954.Jun 18 2015, 1:06 PM
ruiu retitled this revision from to [LLD] COFF: Fix unsafe memory access.
ruiu updated this object.
ruiu edited the test plan for this revision. (Show Details)
ruiu added a reviewer: pcc.
ruiu added a subscriber: Unknown Object (MLST).
pcc accepted this revision.Jun 18 2015, 1:17 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 18 2015, 1:17 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r240046.