Page MenuHomePhabricator

Add a test for expression evaluation while inferior is blocked in a syscall
ClosedPublic

Authored by labath on Jun 17 2015, 2:45 PM.

Diff Detail

Event Timeline

labath updated this revision to Diff 27874.Jun 17 2015, 2:45 PM
labath retitled this revision from to Add a test for expression evaluation while inferior is blocked in a syscall.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added a reviewer: tberghammer.
labath added subscribers: emaste, Unknown Object (MLST).
tberghammer added inline comments.Jun 17 2015, 3:18 PM
test/expression_command/expr-in-syscall/TestExpressionInSyscall.py
53

What gives time to the inferior to reach the syscall?
Should we add a sleep(1) here?

56

(nit): The "idiomatic" way for this is to use the "pass" keyword

labath added inline comments.Jun 17 2015, 3:26 PM
test/expression_command/expr-in-syscall/TestExpressionInSyscall.py
53

The last WaitForEvent call will time out after 2 seconds, when there are no more pending events.

56

Ah, that's good to know.

labath updated this revision to Diff 27881.Jun 17 2015, 3:29 PM

Address review comments.

tberghammer accepted this revision.Jun 17 2015, 3:45 PM
tberghammer edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 17 2015, 3:45 PM
This revision was automatically updated to reflect the committed changes.