We would find an address with matching tag, only to discover in
ShowCandidate that it's very far away from [stack].
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM
compiler-rt/lib/hwasan/hwasan_report.cpp | ||
---|---|---|
438–439 | I'd rather check AddrIsInStack instead of num_descriptions_printed, or record the result of the stack check in a bool variable and look at that. Otherwise this depends on the order of the checks and will become confusing later if the code is moved. | |
439–440 | rename ShowCandidate to ShowHeapOrGlobalCandidate |
I'd rather check AddrIsInStack instead of num_descriptions_printed, or record the result of the stack check in a bool variable and look at that. Otherwise this depends on the order of the checks and will become confusing later if the code is moved.