[LLDB] dotest.py set selected_platform on remote connection

[omjavaid]

Summary

This patch fixes a bug in dotest.py where lldb.selected_platform was
being set to host platform even after a successful connection to a
remote platform via platform url. This patch fixes this behavior and
sets selected_platform to remote_platform after a successful connection.

This patch also removes target_platform variable from run_suite.

[JDevlieghere]

Thanks! LGTM

lldb/packages/Python/lldbsuite/test/dotest.py

if configuration.lldb_platform_name:
             print(
                 "Connecting to remote platform '%s' at '%s'..." %
                 (configuration.lldb_platform_name, configuration.lldb_platform_url))
             platform_connect_options = lldb.SBPlatformConnectOptions(
                 configuration.lldb_platform_url)
             err = lldb.remote_platform.ConnectRemote(platform_connect_options)
             if err.Success():
                 print("Connected.")
+                lldb.selected_platform = lldb.remote_platform
             else:
                 print("error: failed to connect to remote platform using URL '%s': %s" % (
                     configuration.lldb_platform_url, err))
                 exitTestSuite(1)
         else:
             configuration.lldb_platform_url = None
 
     if configuration.lldb_platform_working_dir:
else:
         lldb.remote_platform = None
         configuration.lldb_platform_working_dir = None
         configuration.lldb_platform_url = None
 
     # Set up the working directory.
     # Note that it's not dotest's job to clean this directory.
     lldbutil.mkdir_p(configuration.test_build_dir)
 
-    from . import lldbplatformutil
-    target_platform = lldbplatformutil.getPlatform()
-
     checkLibcxxSupport()
     checkLibstdcxxSupport()
     checkWatchpointSupport()
     checkDebugInfoSupport()
     checkDebugServerSupport()
     checkObjcSupport()
     checkForkVForkSupport()