This is an archive of the discontinued LLVM Phabricator instance.

[mips] [IAS] Add test for SW with relative label operands. NFC.
ClosedPublic

Authored by tomatabacu on Jun 17 2015, 3:06 AM.

Download Raw Diff

Details

Reviewers

Commits

rG6a1e0eb27d01: [mips] [IAS] Add test for SW with relative label operands. NFC.
rL239899: [mips] [IAS] Add test for SW with relative label operands. NFC.

Diff Detail

Event Timeline

tomatabacu updated this revision to Diff 27819.Jun 17 2015, 3:06 AM

tomatabacu retitled this revision from to [mips] [IAS] Add test for SW with $tmp symbol operands. NFC..

tomatabacu updated this object.

tomatabacu edited the test plan for this revision. (Show Details)

tomatabacu added a reviewer: dsanders.

tomatabacu added a parent revision: D9938: [mips] [IAS] Fix LW with relative label operands..

tomatabacu added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Jun 17 2015, 3:31 AM

Nearly forgot: Could you refer to it as 'relative branches' in your commit? Some ABI's will need to use .Ltmp0 when I fix that bug.

'relative branches'

Sorry, 'relative labels'

tomatabacu retitled this revision from [mips] [IAS] Add test for SW with $tmp symbol operands. NFC. to [mips] [IAS] Add test for SW with relative label operands. NFC..Jun 17 2015, 3:46 AM

tomatabacu edited edge metadata.

tomatabacu closed this revision.Jun 17 2015, 4:50 AM

Revision Contents

Path

Size

test/

MC/

Mips/

mips-expansions.s

5 lines

Diff 27819

test/MC/Mips/mips-expansions.s

	Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
	# CHECK: sw $10, %lo(symbol)($1) # encoding: [A,A,0x2a,0xac]			# CHECK: sw $10, %lo(symbol)($1) # encoding: [A,A,0x2a,0xac]
	# CHECK: # fixup A - offset: 0, value: symbol@ABS_LO, kind: fixup_Mips_LO16			# CHECK: # fixup A - offset: 0, value: symbol@ABS_LO, kind: fixup_Mips_LO16

	lw $8, 1f			lw $8, 1f
	# CHECK: lui $8, %hi($tmp0) # encoding: [A,A,0x08,0x3c]			# CHECK: lui $8, %hi($tmp0) # encoding: [A,A,0x08,0x3c]
	# CHECK: # fixup A - offset: 0, value: ($tmp0)@ABS_HI, kind: fixup_Mips_HI16			# CHECK: # fixup A - offset: 0, value: ($tmp0)@ABS_HI, kind: fixup_Mips_HI16
	# CHECK: lw $8, %lo($tmp0)($8) # encoding: [A,A,0x08,0x8d]			# CHECK: lw $8, %lo($tmp0)($8) # encoding: [A,A,0x08,0x8d]
	# CHECK: # fixup A - offset: 0, value: ($tmp0)@ABS_LO, kind: fixup_Mips_LO16			# CHECK: # fixup A - offset: 0, value: ($tmp0)@ABS_LO, kind: fixup_Mips_LO16
				sw $8, 1f
				# CHECK: lui $1, %hi($tmp0) # encoding: [A,A,0x01,0x3c]
				# CHECK: # fixup A - offset: 0, value: ($tmp0)@ABS_HI, kind: fixup_Mips_HI16
				# CHECK: sw $8, %lo($tmp0)($1) # encoding: [A,A,0x28,0xac]
				# CHECK: # fixup A - offset: 0, value: ($tmp0)@ABS_LO, kind: fixup_Mips_LO16

	lw $10, 655483($4)			lw $10, 655483($4)
	# CHECK: lui $10, 10 # encoding: [0x0a,0x00,0x0a,0x3c]			# CHECK: lui $10, 10 # encoding: [0x0a,0x00,0x0a,0x3c]
	# CHECK: addu $10, $10, $4 # encoding: [0x21,0x50,0x44,0x01]			# CHECK: addu $10, $10, $4 # encoding: [0x21,0x50,0x44,0x01]
	# CHECK: lw $10, 123($10) # encoding: [0x7b,0x00,0x4a,0x8d]			# CHECK: lw $10, 123($10) # encoding: [0x7b,0x00,0x4a,0x8d]
	sw $10, 123456($9)			sw $10, 123456($9)
	# CHECK: lui $1, 2 # encoding: [0x02,0x00,0x01,0x3c]			# CHECK: lui $1, 2 # encoding: [0x02,0x00,0x01,0x3c]
	# CHECK: addu $1, $1, $9 # encoding: [0x21,0x08,0x29,0x00]			# CHECK: addu $1, $1, $9 # encoding: [0x21,0x08,0x29,0x00]
	▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines