This is an archive of the discontinued LLVM Phabricator instance.

Differential D104818

Replace python3 with %python in ML inlining tests.
ClosedPublic

Authored by jacobhegna on Jun 23 2021, 2:06 PM.

Details

Reviewers
mtrofin
Commits
rG7c8a50727258: Replace python3 with %python in ML inlining tests.

Diff Detail

Event Timeline

jacobhegna requested review of this revision.Jun 23 2021, 2:06 PM
jacobhegna created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2021, 2:06 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
mtrofin accepted this revision.Jun 23 2021, 2:07 PM
This revision is now accepted and ready to land.Jun 23 2021, 2:07 PM
This revision was landed with ongoing or failed builds.Jun 23 2021, 2:18 PM
Closed by commit rG7c8a50727258: Replace python3 with %python in ML inlining tests. (authored by jacobhegna). · Explain Why
This revision was automatically updated to reflect the committed changes.
jacobhegna added a commit: rG7c8a50727258: Replace python3 with %python in ML inlining tests..
Harbormaster completed remote builds in B110708: Diff 354076.Jun 23 2021, 2:52 PM

Revision Contents

PathSize
llvm/
test/
Transforms/
Inline/
ML/
2 lines
2 lines
2 lines

Diff 354079

llvm/test/Transforms/Inline/ML/bounds-checks-rewards.ll

; Test behavior when inlining policy grows size out of control. ; Test behavior when inlining policy grows size out of control.
; In all cases, the end result is the same: mandatory inlinings must happen. ; In all cases, the end result is the same: mandatory inlinings must happen.
; Also in all cases, we don't record the mandatory inlining (there's nothing to ; Also in all cases, we don't record the mandatory inlining (there's nothing to
; learn from it). ; learn from it).
; However, when we discover we 'trip' over the artificially-low size increase ; However, when we discover we 'trip' over the artificially-low size increase
; factor, we penalize the 'bad' decision. ; factor, we penalize the 'bad' decision.
; REQUIRES: have_tf_api ; REQUIRES: have_tf_api
; ;
; Generate mock model ; Generate mock model
; RUN: rm -rf %t && mkdir %t ; RUN: rm -rf %t && mkdir %t
; RUN: python3 %S/../../../../lib/Analysis/models/generate_mock_model.py %S/../../../../lib/Analysis/models/inlining/config.py %t ; RUN: %python %S/../../../../lib/Analysis/models/generate_mock_model.py %S/../../../../lib/Analysis/models/inlining/config.py %t
; ;
; When the bounds are very wide ("no bounds"), all inlinings happen. ; When the bounds are very wide ("no bounds"), all inlinings happen.
; RUN: opt -passes=scc-oz-module-inliner -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -ml-inliner-model-under-training=%t -training-log=- -enable-ml-inliner=development -ml-advisor-size-increase-threshold=10.0 -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=NOBOUNDS ; RUN: opt -passes=scc-oz-module-inliner -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -ml-inliner-model-under-training=%t -training-log=- -enable-ml-inliner=development -ml-advisor-size-increase-threshold=10.0 -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=NOBOUNDS
; ;
; When the bounds are very restrictive, the first inlining happens but it's ; When the bounds are very restrictive, the first inlining happens but it's
; considered as "bad" (since it trips over the bounds) and its reward is a ; considered as "bad" (since it trips over the bounds) and its reward is a
; penalty. However, the mandatory inlining, which is considered next, happens. ; penalty. However, the mandatory inlining, which is considered next, happens.
; No other inlinings happend. ; No other inlinings happend.
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines

llvm/test/Transforms/Inline/ML/development-training-log.ll

; Test that we can produce a log if we have or do not have a model, in development mode. ; Test that we can produce a log if we have or do not have a model, in development mode.
; REQUIRES: have_tf_api ; REQUIRES: have_tf_api
; Generate mock model ; Generate mock model
; RUN: rm -rf %t && mkdir %t ; RUN: rm -rf %t && mkdir %t
; RUN: python3 %S/../../../../lib/Analysis/models/generate_mock_model.py %S/../../../../lib/Analysis/models/inlining/config.py %t ; RUN: %python %S/../../../../lib/Analysis/models/generate_mock_model.py %S/../../../../lib/Analysis/models/inlining/config.py %t
; ;
; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-model-under-training=%t -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -S < %s | FileCheck %s ; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-model-under-training=%t -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -S < %s | FileCheck %s
; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-model-under-training=%t -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -ml-inliner-output-spec-override=%S/Inputs/test_output_spec.json -S < %s | FileCheck %s --check-prefixes=EXTRA-OUTPUTS,CHECK ; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-model-under-training=%t -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -ml-inliner-output-spec-override=%S/Inputs/test_output_spec.json -S < %s | FileCheck %s --check-prefixes=EXTRA-OUTPUTS,CHECK
; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -S < %s | FileCheck %s ; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-ir2native-model=%S/../../../../unittests/Analysis/Inputs/ir2native_x86_64_model -S < %s | FileCheck %s
; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-model-under-training=%t -S < %s | FileCheck %s --check-prefix=NOREWARD ; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -ml-inliner-model-under-training=%t -S < %s | FileCheck %s --check-prefix=NOREWARD
; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -S < %s | FileCheck %s --check-prefix=NOREWARD ; RUN: opt -enable-ml-inliner=development -passes=scc-oz-module-inliner -training-log=- -S < %s | FileCheck %s --check-prefix=NOREWARD
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

llvm/test/Transforms/Inline/ML/ml-test-development-mode.ll

; The default inliner doesn't elide @adder, it believes it's too costly to inline ; The default inliner doesn't elide @adder, it believes it's too costly to inline
; adder into switcher. The ML inliner carries out that inlining, resulting in ; adder into switcher. The ML inliner carries out that inlining, resulting in
; a smaller result (part of it is that adder gets elided). ; a smaller result (part of it is that adder gets elided).
; ;
; This test uses Inputs/test-module.ll, as it shares it with a similar test ; This test uses Inputs/test-module.ll, as it shares it with a similar test
; for the 'release' mode. ; for the 'release' mode.
; ;
; REQUIRES: have_tf_api ; REQUIRES: have_tf_api
; RUN: rm -rf %t && mkdir %t ; RUN: rm -rf %t && mkdir %t
; RUN: python3 %S/../../../../lib/Analysis/models/generate_mock_model.py %S/../../../../lib/Analysis/models/inlining/config.py %t ; RUN: %python %S/../../../../lib/Analysis/models/generate_mock_model.py %S/../../../../lib/Analysis/models/inlining/config.py %t
; RUN: opt -passes=scc-oz-module-inliner -enable-ml-inliner=default -S < %S/Inputs/test-module.ll 2>&1 | FileCheck %S/Inputs/test-module.ll --check-prefix=DEFAULT ; RUN: opt -passes=scc-oz-module-inliner -enable-ml-inliner=default -S < %S/Inputs/test-module.ll 2>&1 | FileCheck %S/Inputs/test-module.ll --check-prefix=DEFAULT
; RUN: opt -passes=scc-oz-module-inliner -enable-ml-inliner=development -ml-inliner-model-under-training=%t -S < %S/Inputs/test-module.ll 2>&1 | FileCheck %S/Inputs/test-module.ll --check-prefix=CHECK ; RUN: opt -passes=scc-oz-module-inliner -enable-ml-inliner=development -ml-inliner-model-under-training=%t -S < %S/Inputs/test-module.ll 2>&1 | FileCheck %S/Inputs/test-module.ll --check-prefix=CHECK